Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust extraction with better guess for regularisation parameter; fix degeneracies #139

Merged
merged 27 commits into from
Oct 11, 2023
Merged

Robust extraction with better guess for regularisation parameter; fix degeneracies #139

merged 27 commits into from
Oct 11, 2023

Conversation

jeremyneveu
Copy link
Collaborator

@jeremyneveu jeremyneveu commented Sep 28, 2023 •
edited
Loading

Objectives:

  • check for degenerate vectors in jacobian (causing impossibility to in…vert JT_W_J)
  • if regularisation ends on spurious regularisation parameter, use the uncertainty principle to get N_dof * FHWM = Nparams
  • add robustness in psf1d initialisation and find_target initialisation
  • disable implicit multithreading

@coveralls
Copy link

coveralls commented Sep 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6482785574

  • 134 of 140 (95.71%) changed or added relevant lines in 11 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.8%) to 91.448%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spectractor/extractor/chromaticpsf.py 60 62 96.77%
spectractor/fit/fitter.py 38 42 90.48%
Files with Coverage Reduction New Missed Lines %
spectractor/extractor/spectrum.py 1 91.51%
spectractor/extractor/chromaticpsf.py 4 92.17%
spectractor/simulation/simulator.py 5 91.15%
Totals Coverage Status
Change from base Build 6276999074: 0.8%
Covered Lines: 6961
Relevant Lines: 7612
💛 - Coveralls

Jérémy Neveu added 2 commits September 28, 2023 11:23
update version number 3.0 -> 3.0.1
d0dc522
if fitted regularisation parameter is away from optimal one by 3 orde…
abee92b 
…rs of magnitude, use the optimal one (determined with the spectrophotometric uncertainty principle)
@jeremyneveu jeremyneveu self-assigned this Sep 28, 2023
@jeremyneveu jeremyneveu merged commit 20c69d6 into master Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfisherlevine mfisherlevine mfisherlevine approved these changes

Assignees

@jeremyneveu jeremyneveu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyneveu @coveralls @mfisherlevine