make spectrum summary plot #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6273713403
💛 - Coveralls |
Comment on lines
+538
to
+544
| if not np.any([line.fitted for line in self.lines.lines]): | ||
| fwhm_func = interp1d(self.chromatic_psf.table['lambdas'], | ||
| self.chromatic_psf.table['fwhm'], | ||
| fill_value=(parameters.CALIB_PEAK_WIDTH, parameters.CALIB_PEAK_WIDTH), | ||
| bounds_error=False) | ||
| detect_lines(self.lines, self.lambdas, self.data, self.err, fwhm_func=fwhm_func, | ||
| calibration_lines_only=True) |
There was a problem hiding this comment.
This whole block feels a bit surprising/scary to me. If there's nothing fitted yet, I think failing/returning False or something would be fine, or just plotting what you can too, without the calibrations applied, but actually detecting lines inside a plotting function is a bit weird, no?
There was a problem hiding this comment.
Yeah, but the fitted results are not stored in the .fits files. So when I load a Spectrum from a FITS I need to refit the lines. Should not be a problem for AuxTel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.