Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloured log output's WARNING colour is black #34

Open
mfisherlevine opened this issue Jul 31, 2019 · 2 comments
Open

Coloured log output's WARNING colour is black #34

mfisherlevine opened this issue Jul 31, 2019 · 2 comments

Comments

@mfisherlevine
Copy link
Collaborator

The colourful output logs are really nice, but the colour of WARNING is black. Many people (including myself) have black terminals, and I didn't realise that some of the WARNING level messages were warnings until I copied and pasted the text and happened to see this pop up!

I would suggest maybe changing to red, as only the sickest of people would have an #ff0000 background in their terminal.

@jeremyneveu
Copy link
Collaborator

Actually every INFO/DEBUG/WARNING/ERROR labels are black. I don't find how to set them with the same color of the messager individually, but I propose to set them as white.

@jeremyneveu
Copy link
Collaborator

from spectractor.config import set_logger
from spectractor import parameters

class Test:
    def __init__(self):

        self.my_logger = set_logger(self.__class__.__name__)

    def log(self):
        self.my_logger.info('This info test function works.')


        self.my_logger.debug('This debug test function works.')
        self.my_logger.warning('This warning test function works.')

parameters.VERBOSE = True
parameters.DEBUG = True
test = Test()

Try this and have a look at commit 904aa21

jeremyneveu pushed a commit that referenced this issue Aug 25, 2023
DM-38403-ghafix: Hotfix for unnecessary GHA check of simbad connectivity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants