-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projected correlation function support #1128
base: master
Are you sure you want to change the base?
Conversation
- Compute the 3D correlation function xi_ab(r,z) integrating using FFTLog. - Calculate the window function and use it to obtain w_ab.
- Not the best way to do this.
# Conflicts: # pyccl/correlations.py
Pull Request Test Coverage Report for Build 11834124744Details
💛 - Coveralls |
Some top level feedback without going into the details:
|
@chrgeorgiou can I check what the status of this PR is? |
Hi @damonge, I just received a benchmark code from Elisa, I will tick the points raised above soon and update the PR. |
@elisachisari Here is an update on this. I have run the benchmark code, saved the resulting file in the benchmark data and created a benchmark test. I also created an example in the CellsCorrelations.ipynb in CCLX. In terms of documentation, I take it you are referring to the CCL/doc, I can add this there too. I have to note that the code developed here is only able to compute the projected correlations over infinite baseline (so |
@chrgeorgiou @elisachisari can I check what the status of this is? Is it meant to be ready for review? |
Hi David, I think the development is enough to have this merged from my side, but I would like to hear what Elisa thinks as well. |
This PR adds support for computing projected correlation functions with CCL. These have the form:
with$W(z)$ a window function that depends on the redshift distribution, $P(k,a)$ the relevant power spectrum and $J_n$ the bessel function. This function is often used in direct measurements of galaxy clustering and intrinsic alignments.
This PR uses the FFTLog wrapper in CCL (similarly to what is used in the halo model) to speed-up the integration.