Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projected correlation function support #1128

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

chrgeorgiou
Copy link
Contributor

This PR adds support for computing projected correlation functions with CCL. These have the form:

$w_{ab}(r_p)=\int dz \ W(z)\int\frac{dk \ k}{2\pi^2} \ P(k,a) \ J_n(k \ r_p)$

with $W(z)$ a window function that depends on the redshift distribution, $P(k,a)$ the relevant power spectrum and $J_n$ the bessel function. This function is often used in direct measurements of galaxy clustering and intrinsic alignments.

This PR uses the FFTLog wrapper in CCL (similarly to what is used in the halo model) to speed-up the integration.

@coveralls
Copy link

coveralls commented Oct 18, 2023

Pull Request Test Coverage Report for Build 11834124744

Details

  • 35 of 51 (68.63%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 97.194%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyccl/correlations.py 35 51 68.63%
Totals Coverage Status
Change from base Build 11816689318: -0.2%
Covered Lines: 6547
Relevant Lines: 6736

💛 - Coveralls

@chrgeorgiou chrgeorgiou marked this pull request as ready for review October 18, 2023 10:03
@elisachisari
Copy link
Collaborator

elisachisari commented Dec 7, 2023

Some top level feedback without going into the details:

  • could you add a benchmark?
  • could you add an example in CCLX?
  • could you edit the docs files so this new function is included there?

@damonge
Copy link
Collaborator

damonge commented Feb 21, 2024

@chrgeorgiou can I check what the status of this PR is?

@chrgeorgiou
Copy link
Contributor Author

Hi @damonge, I just received a benchmark code from Elisa, I will tick the points raised above soon and update the PR.

@chrgeorgiou
Copy link
Contributor Author

@elisachisari Here is an update on this. I have run the benchmark code, saved the resulting file in the benchmark data and created a benchmark test. I also created an example in the CellsCorrelations.ipynb in CCLX. In terms of documentation, I take it you are referring to the CCL/doc, I can add this there too.

I have to note that the code developed here is only able to compute the projected correlations over infinite baseline (so $\Pi_\mathrm{max}=\infty$). Having an arbitrarily defined $\Pi_\mathrm{max}$ will need more development if the FFTLog method is to be used. I am happy to continue with this PR as is and add this feature at a later time if requested.

@damonge damonge closed this Jun 18, 2024
@damonge damonge reopened this Jun 18, 2024
@damonge
Copy link
Collaborator

damonge commented Nov 14, 2024

@chrgeorgiou @elisachisari can I check what the status of this is? Is it meant to be ready for review?

@chrgeorgiou
Copy link
Contributor Author

Hi David, I think the development is enough to have this merged from my side, but I would like to hear what Elisa thinks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants