[functionality] add functionality field to program #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
reviewed
Oct 30, 2024
src/compiler.ml
Outdated
| kinds, type_abbrevs, types | ||
| let kinds, type_abbrevs, types, functional_preds = | ||
| if hash = base_hash then | ||
| precomputed_kinds, precomputed_type_abbrevs, precomputed_types, functional_preds |
There was a problem hiding this comment.
The idea is that type checkig requires to merge some stuff. the precomputed_stuff is already merged.
I have some use cases in which the base used for type checking is not the base used for linking (a bit unsafe at the moment).
If the base is the same for both steps, the already merged stuff can be used. If not, one has to merge since the base changed and the precomputed values are wrong.
If it is also the case for functional_preds, follow the name schema/field positions a the other stuff.
If not, don't computed functional_preds in this if-then-else.
gares
reviewed
Nov 4, 2024
| % In the implementation using the input mode of elpi this is no more true. | ||
| f X Y :- q X, r X Y. | ||
|
|
||
| main :- std.findall (f _ _) L, print L. |
|
nice test suite. I think all the tests that pass you should run a findall and assert the length of the returned list is < 2 |
…uted_functional_preds to checked_compilation_unit
gares
added a commit
that referenced
this pull request
Nov 21, 2024
[functionality] add functionality field to program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet no functionality check but we have the infrastructure to know what predicates are functional and what is the functionality relation of its arguments.
This partially works with type abbreviations, a wrong compiled functionality is given by the following program:where the functionality of the argumentAofxis forgottenTo solve this issue we need an abstraction constructor in the functionality type