Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix #725

Merged
merged 2 commits into from
Dec 2, 2024
Merged

nix #725

merged 2 commits into from
Dec 2, 2024

Conversation

gares
Copy link
Contributor

@gares gares commented Dec 2, 2024

No description provided.

@gares
Copy link
Contributor Author

gares commented Dec 2, 2024

@CohenCyril help plz. Isn't this the way you override the version of elpi?

  bundles = {

    "coq-8.20" = {
      coqPackages = common-bundles // {
        coq.override.version = "8.20";
      };
      ocamlPackages = {
        elpi.override.version = "v2.0.3";
      };
    };

@CohenCyril
Copy link
Collaborator

@gares for some strange reason that I cannot recall the version of elpi at use is locally overriden in the definition of the coq-elpi derivation... AFACT this looks like bad practice. Perhaps the reason is that when we override coq-elpi there is a high chance that we want to override elpi at the same time and this does the job in a confusing way.
Anyway I will push a patch asap and later this week try to fix it upstream.

@CohenCyril
Copy link
Collaborator

       error: ppxlib-0.15.0 is not available for OCaml 4.14.2

what version of ocaml is appropriate?

@gares
Copy link
Contributor Author

gares commented Dec 2, 2024

That version is fine, 4.13 is the minimum

@gares
Copy link
Contributor Author

gares commented Dec 2, 2024

Who fixés ppxlib?

@CohenCyril
Copy link
Collaborator

Ok, I see, the problem is a backward compatibility layer. I'm getting rid of it here.

@gares gares merged commit 78af386 into master Dec 2, 2024
100 of 102 checks passed
@gares gares deleted the fix-nix branch December 2, 2024 12:43
@gares
Copy link
Contributor Author

gares commented Dec 2, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants