[coq.TC.get-inst-prio] new get-inst-prio (#716) #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the new push, I'm not sure the tc-priority remains relevant, orelse, if we want to keep this piece of information we need to reuse the old algorithm to know if the instance has a UserGiven priority. Note that in that case, I'm not sure how to know if a hint (added with hint resolve) has a UserGiven priority |
|
In these cases I think having the exception carry the found value is less cumbersome. Otherwise looks good. |
FissoreD
force-pushed
the
new-inst-prio
branch
from
6f52557 to
30995f3
Compare
gares
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.