ifdefs on elpi version in source code #693
Conversation
|
@vbgl I need some nix expertise here. |
|
I think the problem comes from the fact that |
|
Hem, ok, thanks for explaining. Next question is: how can I fix that? Is using the tarball generated by dune-release a problem for nix? |
|
I’ll propose a patch for nixpkgs asap. What is suppose to happen to your dune scripts (in coq-elpi) when using a development version (i.e., not a release with a proper version string) of elpi? |
etc/version_parser.ml
Outdated
| (* sanitization *) | ||
| let l = | ||
| match l with | ||
| | l when List.for_all is_number l -> l | ||
| | ["%%VERSION_NUM%%"] -> ["99";"99";"99"] | ||
| | _ -> Printf.eprintf "version_parser: cannot parse: %s\n" v; exit 1 in |
There was a problem hiding this comment.
@vbgl this was my "attempt" to support development versions. I'm happy to improve on that
|
The fix has been merged into nixpkgs master branch. I hope this addresses you problems. Please ping again if it’s not the case. Kudos to Cyril for the patch. |
|
@CohenCyril opam works on master, but not nix. Since I can't run nix on my machine, is there any chance to get verbose logs in CI? |
|
I mean, the CI file is generated, and it contains |
No description provided.