Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS app #577

Merged
merged 4 commits into from
Jan 26, 2024
Merged

CS app #577

merged 4 commits into from
Jan 26, 2024

Conversation

Tragicus
Copy link
Contributor

Canonical structure hook, with a copy of evarconv.ml so that we can make modifications locally and override Coq's current behavior.
N.B. This can evolve easily into an unification hook.
At this time, it is mostly untested.

Copy link
Contributor

@gares gares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!!!

There is file which should be removed (it is generated).
I'd also like canonical-solution to be shorted, maybe cs or csolution.

@@ -0,0 +1,100 @@
let _ = Mltop.add_known_module "coq-elpi-cs.plugin"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be in .gitignore, not committed

@gares gares marked this pull request as ready for review January 25, 2024 20:30
% - [Ctx] is the context
% - [Lhs] and [Rhs] are the terms to unify
:index (0 6 6)
pred canonical-solution i:goal-ctx, o:term, o:term.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and rename the file plz


Elpi Accumulate cs.db lp:{{

canonical-solution _ {{ sort lp:Sol }} {{ nat }} :-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

@Tragicus
Copy link
Contributor Author

I do not understand what happens with the compilation. There is no "Replace" in the code and yet it magically appears in the .cmt file.

@gares gares merged commit ac73738 into LPCIC:master Jan 26, 2024
16 of 18 checks passed
@Tragicus Tragicus deleted the cs branch January 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants