-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS app #577
CS app #577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!!!
There is file which should be removed (it is generated).
I'd also like canonical-solution
to be shorted, maybe cs
or csolution
.
apps/cs/src/coq_elpi_cs_hook.ml
Outdated
@@ -0,0 +1,100 @@ | |||
let _ = Mltop.add_known_module "coq-elpi-cs.plugin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be in .gitignore, not committed
apps/cs/TODOREADME.md
Outdated
% - [Ctx] is the context | ||
% - [Lhs] and [Rhs] are the terms to unify | ||
:index (0 6 6) | ||
pred canonical-solution i:goal-ctx, o:term, o:term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix and rename the file plz
apps/cs/tests/test_cs.v
Outdated
|
||
Elpi Accumulate cs.db lp:{{ | ||
|
||
canonical-solution _ {{ sort lp:Sol }} {{ nat }} :- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
I do not understand what happens with the compilation. There is no "Replace" in the code and yet it magically appears in the .cmt file. |
Canonical structure hook, with a copy of
evarconv.ml
so that we can make modifications locally and override Coq's current behavior.N.B. This can evolve easily into an unification hook.
At this time, it is mostly untested.