Coercion hook #545
Closed
Coercion hook #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the only issue left with this is the naming of the variables used to define the product type used as placeholder for Funclass in apps/coercion/src/coq_elpi_coercion_hook.mlg. Is there a way to generate automatically the name. If not, is there a convention? |
|
look here https://github.com/coq/coq/blob/970bb08b37f7e05b5b4a36b604174e3f274c4105/engine/namegen.mli |
|
Ok, thanks. I did something, hopefully it is sensible. |
Tragicus
force-pushed
the
coercion
branch
2 times, most recently
from
eda7879 to
20f662b
Compare
This was referenced Feb 14, 2024
|
Note that since Coq 8.19 will never get the fixed hook, this PR is probably useless and superseeded by #596 (which will end up in master when it will be merged with coq-master to move to Coq 8.20). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on the coercion hook on coq-elpi's side, reflecting the changes in Coq (see coq/coq#18236 (comment)).