Add "coq.env.query-extra-dep" external predicate #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phikal
force-pushed
the
query-extra-dep
branch
from
6b65ec9 to
4fe9ddc
Compare
gares
requested changes
Oct 21, 2023
tests/test_query_extra_dep.v
Outdated
|
|
||
| Elpi Query lp:{{ coq.env.query-extra-dep "elab" File }}. | ||
|
|
||
| Fail Elpi Query lp:{{ coq.env.query-extra-dep "foo" File }}. |
There was a problem hiding this comment.
Please add the test file to _CoqProject.test.
This file is a good test, but the API returns None instead of raising No_clause, so this will fail once it runs.
src/coq_elpi_builtins.ml
Outdated
| @@ -2325,6 +2325,15 @@ denote the same x as before.|}; | |||
| Some (c, np + na))))))), | |||
| DocAbove); | |||
|
|
|||
| MLCode(Pred("coq.env.query-extra-dep", | |||
There was a problem hiding this comment.
coq.env is for accessing the logical environment.
Please move this code just before
-- Datatypes conversions --------------------------------------------
maybe in a dedicated section, say -- Extra Dependency ------------------------.
Also I'd call it coq.extra-dep
|
Enrico Tassi ***@***.***> writes:
@gares requested changes on this pull request.
Thanks for this PR.
There are a few things to improve before merging, see the comments.
You should also add a line to the ChangeLog.md file
Done.
> @@ -0,0 +1,7 @@
+From elpi Require Import elpi.
+
+From unreleased Extra Dependency "elpi_elaborator.elpi" as elab.
+
+Elpi Query lp:{{ coq.env.query-extra-dep "elab" File }}.
+
+Fail Elpi Query lp:{{ coq.env.query-extra-dep "foo" File }}.
Please add the test file to _CoqProject.test.
This file is a good test, but the API returns None instead of raising
`No_clause`, so this will fail once it runs.
I've replaced it with an example that matches (some _).
> @@ -2325,6 +2325,15 @@ denote the same x as before.|};
Some (c, np + na))))))),
DocAbove);
+ MLCode(Pred("coq.env.query-extra-dep",
`coq.env` is for accessing the logical environment.
Please move this code just before
```
-- Datatypes conversions --------------------------------------------
```
maybe in a dedicated section, say `-- Extra Dependency ------------------------`.
Also I'd call it `coq.extra-dep`
Fine with me, I've also changed this.
|
phikal
force-pushed
the
query-extra-dep
branch
from
4fe9ddc to
c8e9e2c
Compare
gares
requested changes
Oct 21, 2023
| @@ -3884,6 +3884,15 @@ Supported attributes: | |||
| state, !: s, [])), | |||
| DocAbove); | |||
|
|
|||
| MLCode(Pred("coq.extra-dep", | |||
There was a problem hiding this comment.
Please add an LPDoc line with something like
-- Extra Dependencies -------------
coq-builtin.elpi
Outdated
| @@ -901,6 +901,10 @@ external pred coq.env.projections i:inductive, o:list (option constant). | |||
| external pred coq.env.primitive-projections i:inductive, | |||
| o:list (option (pair projection int)). | |||
|
|
|||
| % [coq.env.query-extra-dep Identifier File Name] Resolve the file name of an | |||
phikal
force-pushed
the
query-extra-dep
branch
from
c8e9e2c to
995505a
Compare
|
Sorry, missed those. |
gares
approved these changes
Oct 21, 2023
|
Do you have a schedule when you are planning to publish a release with these changes? |
|
Before the end of November |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Zulip, this would allow for a predicate to resolve the real path behind a
Extra Dependency. As seen in the patch, this just amounts to wrappingComExtraDeps.query_extra_depin the right way.