Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
gares authored Dec 1, 2023
1 parent 84cce0d commit c390224
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
2 changes: 1 addition & 1 deletion Makefile.coq.local
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ install-extra::
df="`$(COQMKFILE) -destination-of theories/elpi.vo $(COQLIBS)`";\
install -m 0644 elpi-builtin.elpi "$(COQLIBINSTALL)/$$df";\
install -m 0644 coq-builtin.elpi "$(COQLIBINSTALL)/$$df";\
install -m 0644 coq-builtin-parsing-phase.elpi "$(COQLIBINSTALL)/$$df";\
install -m 0644 coq-builtin-synterp.elpi "$(COQLIBINSTALL)/$$df";\
install -m 0644 elpi/coq-lib.elpi "$(COQLIBINSTALL)/$$df";\
install -m 0644 elpi/elpi_elaborator.elpi "$(COQLIBINSTALL)/$$df"

11 changes: 0 additions & 11 deletions apps/NES/elpi/nes_synterp.elpi
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ ns->modpath (ns _ M) M.
pred open-ns->string i:prop, o:string.
open-ns->string (open-ns S _) S.

pred mk-fresh i:string, o:string.
mk-fresh NS Fresh :- Fresh is NS ^ "_aux_" ^ {std.any->string {new_int} }.

pred begin-ns i:string, i:list string, i:list prop, o:list prop.
begin-ns NS Path In Out :-
if (Path = [])
Expand Down Expand Up @@ -170,13 +167,5 @@ resolve.walk S Ctx SP Path :- std.do! [
pred resolve.err i:string.
resolve.err S :- coq.error "NES: Namespace not found:" S.

% % The (closed) namespace [NS] containing global [GR], or [].
% pred gref->path i:gref, o:list string.
% gref->path GR NS :- std.do! [
% coq.gref->path GR MP,
% if (gref->path.aux MP NS) true (NS = []),
% ].
% pred gref->path.aux i:list string, o:list string.
% gref->path.aux MP NS :- ns NS M, coq.modpath->path M MP, !.

}
1 change: 0 additions & 1 deletion apps/NES/tests/test_NES.v
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Fail NES.Begin "A._.B".

(* name space creation *)
NES.Begin Foo.
#[synterp] Elpi Print NES.End.
Definition x := 3.
NES.End Foo.
Print Foo.x.
Expand Down

0 comments on commit c390224

Please sign in to comment.