Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS Adds ability to publish an rtcm_msgs Message instead of a mavros_msgs RTCM #22

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

robbiefish
Copy link
Contributor

  • Adds launch file parameter rtcm_message_package which can be specified as one of the following:

@PaulBouchier
Copy link

Thank you for implementing this new feature. I tested branch feature/ros_rtcm_msgs to make sure it all worked properly, and it did. (I passed in the arg rtcm_message_package set to rtcm_msgs, and my F9P acquired RTK Fixed mode right away using my local rtk2go ntrip server.

I want to recommend an additional change: document the new launch arguments in README.md. Perhaps some explanatory text that identifies the two different message packages supported would be appropriate. Separately, I noticed the new args ntrip_version and debug are not documented in the README either (but maybe they're documented on a different branch).

This PR fixes my issue #10 and I think it should be merged after the README fix proposed, and the issue closed. Thanks again for the enhancement - you guys rock!

@robbiefish
Copy link
Contributor Author

@PaulBouchier I am glad this worked well for you.

The readme is pretty far behind on documentation. I will make a separate PR to update the readme with all the new launch params and try to be better about adding the documentation in the PR from now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ntrip_client should support ZED-F9P for applications other than mav-ros - i.e. support KumarRobotics driver
2 participants