Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions about funding wallet #54

Merged
merged 2 commits into from
Jul 30, 2022

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jul 16, 2022

No description provided.

@crisdut crisdut force-pushed the fix/update-install-instructions branch from 3f02ad3 to bd67657 Compare July 16, 2022 13:15
Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think we got rid of the need for installing SQLite, ZMQ and SSL - no SQLite & SSL use anymore in the code and dependencies + ZMQ is always shipped in a vendored option. Can you pls confirm that it would work if we remove the prerequisite installation?

@dr-orlovsky dr-orlovsky added the documentation Improvements or additions to documentation label Jul 16, 2022
@crisdut
Copy link
Member Author

crisdut commented Jul 18, 2022

I removed the dependencies, and everything is running correctly.

@crisdut crisdut requested a review from dr-orlovsky July 18, 2022 20:14
@dr-orlovsky dr-orlovsky merged commit 0e6b6c0 into LNP-WG:master Jul 30, 2022
@crisdut crisdut deleted the fix/update-install-instructions branch January 26, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants