Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB: hashing bulletproof commitments; closes #106 #107

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

dr-orlovsky
Copy link
Member

No description provided.

@dr-orlovsky dr-orlovsky added *security* Security-related issues feature New functionality *consensus* Changes breaking existing consensus rules labels Sep 23, 2020
@dr-orlovsky dr-orlovsky added this to the v0.1.0 Release milestone Sep 23, 2020
@dr-orlovsky dr-orlovsky self-assigned this Sep 23, 2020
@dr-orlovsky dr-orlovsky linked an issue Sep 23, 2020 that may be closed by this pull request
@dr-orlovsky dr-orlovsky added the *scalability* Issues important for scalability label Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #107 into master will decrease coverage by 3.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #107     +/-   ##
========================================
- Coverage    57.8%   54.3%   -3.5%     
========================================
  Files          59      59             
  Lines        6408    5959    -449     
========================================
- Hits         3705    3238    -467     
- Misses       2703    2721     +18     
Impacted Files Coverage Δ
src/paradigms/client_side_validation.rs 84.1% <100.0%> (+2.3%) ⬆️
src/rgb/contract/amount.rs 90.7% <100.0%> (+0.1%) ⬆️
src/rgb/contract/testutils.rs 100.0% <100.0%> (ø)
src/rgb/schema/types.rs 68.2% <0.0%> (ø)
src/rgb/contract/data.rs 76.5% <0.0%> (ø)
src/rgb/schema/script.rs 52.2% <0.0%> (ø)
src/common/data_format.rs 0.0% <0.0%> (ø)
src/rgb/stash/consignment.rs 46.5% <0.0%> (ø)
src/bp/chain.rs
src/bp/network.rs 23.2% <0.0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eadc61e...c7890f0. Read the comment docs.

@dr-orlovsky dr-orlovsky merged commit 232d728 into master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Changes breaking existing consensus rules feature New functionality *scalability* Issues important for scalability *security* Security-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulletproof optimization phase I: commit_encode thorough hashes
1 participant