Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNPBP-1 adjustment according to bitcoin consensus rules #66

Closed
dr-orlovsky opened this issue Oct 6, 2020 · 0 comments · Fixed by #67
Closed

LNPBP-1 adjustment according to bitcoin consensus rules #66

dr-orlovsky opened this issue Oct 6, 2020 · 0 comments · Fixed by #67
Assignees
Labels
bug Something isn't working [DBC] Deterministic bitcoin commitments
Milestone

Comments

@dr-orlovsky
Copy link
Member

We must add condition that LNPBP-1 procedure must fail in case the tweaking factor greater than Sepck256k1 base point G order n.

This condition was absent before, because tweaking overflow does not affect commitment security due to DLP. However, while secp256k1 library tweaking function (used by Bitcoin Core) fails and we can't change its behavior, we have no other option than to fail as well.

@dr-orlovsky dr-orlovsky added bug Something isn't working [DBC] Deterministic bitcoin commitments labels Oct 6, 2020
@dr-orlovsky dr-orlovsky added this to the DBC: proposals milestone Oct 6, 2020
@dr-orlovsky dr-orlovsky self-assigned this Oct 6, 2020
dr-orlovsky added a commit that referenced this issue Oct 7, 2020
@dr-orlovsky dr-orlovsky linked a pull request Oct 7, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [DBC] Deterministic bitcoin commitments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant