Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

build(flow): ignore config-chain/test/broken.json #783

Merged

Conversation

mrfelton
Copy link
Member

Description:

Ignore invalid json files in flow config to prevent expected failures from producing errors.

See facebook/flow#869

Motivation and Context:

We are getting this error when running flow:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/npm/node_modules/config-chain/test/broken.json:11:3

Unexpected string

      8│     "url": "https://github.com/dominictarr/config-chain.git"
      9│   }
     10│   //missing , and then this comment. this json is intensionally invalid
     11│   "dependencies": {
     12│     "proto-list": "1",
     13│     "ini": "~1.0.2"
     14│   },

See facebook/flow#2364

How Has This Been Tested?

run yarn flow and verify error is no longer produced,

Screenshots (if appropriate):

Types of changes:

Bug fix

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the scope: devops issues that affect devops label Sep 19, 2018
@mrfelton mrfelton added this to the v0.2.2-beta milestone Sep 19, 2018
@mrfelton mrfelton self-assigned this Sep 19, 2018
Ignore invalid json files in flow config to prevent expected failures
from producing errors.

See facebook/flow#869
@mrfelton mrfelton force-pushed the fix/flow-ignore-broken-config-chain branch from 95b5b7a to 1de5ae6 Compare September 19, 2018 12:29
@mrfelton mrfelton merged commit 08d1bdf into LN-Zap:master Sep 19, 2018
@coveralls
Copy link

coveralls commented Sep 19, 2018

Coverage Status

Coverage remained the same at 16.201% when pulling 1de5ae6 on mrfelton:fix/flow-ignore-broken-config-chain into 800ece4 on LN-Zap:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: devops issues that affect devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants