Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

ci(jest): remove detectOpenHandles flag #778

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

mrfelton
Copy link
Member

Description:

The detectOpenHandles flag was added to help pin down an issue that we were facing with some of our tests a while back. This flag comes with a very high performance penalty and is no longer needed in our setup.

Motivation and Context:

Slow builds.

Types of changes:

CI improvement

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the scope: devops issues that affect devops label Sep 19, 2018
@mrfelton mrfelton added this to the v0.2.2-beta milestone Sep 19, 2018
@mrfelton mrfelton self-assigned this Sep 19, 2018
@coveralls
Copy link

coveralls commented Sep 19, 2018

Coverage Status

Coverage remained the same at 16.201% when pulling a3d6755 on mrfelton:ci/remove-detect-open-handles into 35fe497 on LN-Zap:master.

The detectOpenHandles flag was added to help pin down an issue that we
were facing with some of our tests a while back. This flag comes with a
very high performance penalty and is no longer needed in our setup.
@mrfelton mrfelton force-pushed the ci/remove-detect-open-handles branch from d6c8b80 to a3d6755 Compare September 19, 2018 11:33
@mrfelton mrfelton merged commit 800ece4 into LN-Zap:master Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: devops issues that affect devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants