Skip to content

Commit

Permalink
Revert previous change commenting out the Mac Legacy build, but don't…
Browse files Browse the repository at this point in the history
… expect it in the final step instead.
  • Loading branch information
michaelherger committed Oct 24, 2024
1 parent eb93fe2 commit 137bfaf
Showing 1 changed file with 25 additions and 24 deletions.
49 changes: 25 additions & 24 deletions .github/workflows/00_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,29 +21,30 @@ on:
- release

jobs:
# comment out this step, as disabling it would fail the success() check later
# macLegacy:
# name: Build LMS for Mac (Legacy)
# runs-on: self-hosted
# timeout-minutes: 20
# env:
# BASEDIR: gh-build
# steps:
# # we must check out here, as otherwise the build action is not available
# - name: Check out LMS code
# uses: actions/checkout@v4
# with:
# path: server
# ref: ${{ inputs.branch }}

# - name: Launch build process
# uses: ./server/.github/actions/build
# with:
# build-params: macosx
# build-type: ${{ inputs.build_type }}
# ssh-connect-string: ${{ secrets.MAC_CONNECT_STRING }}
# AWS_KEY_ID: ${{ secrets.R2_KEY_ID }}
# AWS_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }}
macLegacy:
name: Build LMS for Mac (Legacy)
# disable - no longer provided starting LMS9
if: false
runs-on: self-hosted
timeout-minutes: 20
env:
BASEDIR: gh-build
steps:
# we must check out here, as otherwise the build action is not available
- name: Check out LMS code
uses: actions/checkout@v4
with:
path: server
ref: ${{ inputs.branch }}

- name: Launch build process
uses: ./server/.github/actions/build
with:
build-params: macosx
build-type: ${{ inputs.build_type }}
ssh-connect-string: ${{ secrets.MAC_CONNECT_STRING }}
AWS_KEY_ID: ${{ secrets.R2_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }}

mac:
name: Build LMS for Mac (MenuBar Item)
Expand Down Expand Up @@ -177,7 +178,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 2
needs:
- macLegacy
# - macLegacy
- mac
- linux
- win64
Expand Down

0 comments on commit 137bfaf

Please sign in to comment.