Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink mixer channel strip #7502

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

sakertooth
Copy link
Contributor

@sakertooth sakertooth commented Sep 17, 2024

Lots of user complained that the mixer channel strip got a lot larger after the layout rework in #6591. This PR shrinks the mixer channel strip by removing the content margins and any spacing between the child widgets.

Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakertooth
Copy link
Contributor Author

The lack of padding with the peak indicators feels a bit odd, but maybe it's just me. If anything, it can be fixed later.

@sakertooth sakertooth merged commit 4803bbb into LMMS:master Sep 18, 2024
11 checks passed
@sakertooth sakertooth deleted the shrink-channel-strip branch September 18, 2024 08:45
sakertooth added a commit to sakertooth/lmms that referenced this pull request Sep 19, 2024
Remove all content margins and spacing between child widgets for each mixer channel strip.
mmeeaallyynn pushed a commit to mmeeaallyynn/lmms that referenced this pull request Oct 27, 2024
Remove all content margins and spacing between child widgets for each mixer channel strip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants