Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up some gui elements to theming #7314

Merged
merged 11 commits into from
Nov 30, 2024
Merged

Conversation

zonkmachine
Copy link
Member

Make some elements themeable.

Example: EnvelopeGraph/LfoGraph

/* Envelope graph */
lmms--gui--EnvelopeGraph {
	qproperty-noAmountColor: grey;
	qproperty-fullAmountColor: pink;
	qproperty-markerFillColor: transparent;
	qproperty-markerOutlineColor: black;
}

pink

Example: Step editor, last edited note
stepeditor

Fixes #7306

@Rossmaxx
Copy link
Contributor

@zonkmachine is there anything else left here?

Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but LGTM

@Rossmaxx Rossmaxx merged commit 3562bbe into LMMS:master Nov 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow theming of elements with hardcoded color values
4 participants