-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve search performance in FileBrowser
#6962
Conversation
f409251
to
bf3ef9a
Compare
FileBrowser
FileBrowser
Realized that this PR was far too invasive for little benefit other than search performance, so I put the focus on just that rather than a lot of unnecessary changes. Edit: I was originally worried that trying to build the search tree on the main thread will freeze it up. It does for large enough directories (and very basic queries), but LMMS having to search through the entire root and home directories is largely unnecessary. This PR gives us a much needed boost in performance in general, but the next step would still be to minimize the search space. |
Improves the search performance of the file browser by delegating the search to a worker thread. The main thread then builds the tree and displays it to the user.
Fixes #6874.