Fix a Jack audio segfault #6912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice: Low probability, but might fix #5954 . Though that issue might have already been fixed in the last 2 years. |
Veratil
reviewed
Oct 1, 2023
JohannesLorenz
force-pushed
the
jack-audio-segfault
branch
from
8505fb4
to
17fde2c
Compare
messmerd
reviewed
Oct 15, 2023
PhysSong
approved these changes
Oct 31, 2023
JohannesLorenz
force-pushed
the
jack-audio-segfault
branch
from
c0dec33
to
3803e52
Compare
The segfault happens when you use buffersize 224: Then, in AudioJack.cpp, L424, `done` can be greater than `_nframes`.
These were done with `clang-format`, and slight patching where `clang-format` was a bit weird.
JohannesLorenz
force-pushed
the
jack-audio-segfault
branch
from
3803e52
to
84b3931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some formatting fixes using
clang-format.The segfault happens when you use buffersize 224: Then, in
lmms/src/core/audio/AudioJack.cpp
Line 424 in e1cc63b
donecan be greater than_nframes.