Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4984 - Remove maximize from Meter (Metro) menu #5071

Merged
merged 1 commit into from
Sep 8, 2019

Conversation

malcops
Copy link
Contributor

@malcops malcops commented Jul 7, 2019

Tested locally that the Meter menu does not have a maximize button, and cannot be resized.

First time contributor, and new to Qt.. any feedback is welcome of course.

@malcops malcops force-pushed the feature/pm/meter-no-maximize-button branch from 15fb9e4 to b917528 Compare July 7, 2019 16:43
@kdeng00
Copy link
Contributor

kdeng00 commented Jul 8, 2019

Hey @malcops, funny enough I was working on the same issue as a first-time contributor. I fixed the sizing issue and was going to work on preventing the Meter window from being maximized but forgot the issue # then checked and to see that you made the commit.

@cassdeckard
Copy link

This fixes #4984 , no?

@malcops
Copy link
Contributor Author

malcops commented Jul 25, 2019

@mattdeckard yes it fixes #4984

@DomClark
Copy link
Member

I don't think there's a need to keep a pointer to the subwindow in an m_subWindow member. It can stay local to showCustom.

src/gui/widgets/TempoSyncKnob.cpp Outdated Show resolved Hide resolved
@DomClark
Copy link
Member

Can this be merged now, or does it still need testing? Also, the new code doesn't quite follow the coding conventions on spaces within parentheses, but does match the surrounding style.

@malcops If you edit the initial comment here to include the words "fixes #4984", GitHub will automatically close that issue when this pull request is merged.

@PhysSong PhysSong dismissed BaraMGB’s stale review August 24, 2019 02:25

Related issues are fixed.

@DomClark DomClark added the needs testing This pull request needs more testing label Aug 25, 2019
@malcops malcops force-pushed the feature/pm/meter-no-maximize-button branch from b6d32ef to 2df0553 Compare August 27, 2019 23:09
@malcops
Copy link
Contributor Author

malcops commented Aug 28, 2019

@DomClark squashed the fixup commits and changed commit message. Left the spaces within parentheses as is, but let me know if you wanted that changed as well.

@malcops malcops changed the title Issue #4984 Remove maximize from Meter (Metro) menu Fixes #4984 - Remove maximize from Meter (Metro) menu Aug 28, 2019
@PhysSong PhysSong merged commit e1236f5 into LMMS:master Sep 8, 2019
@zonkmachine zonkmachine removed the needs testing This pull request needs more testing label Sep 8, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants