-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI flag to disconnect all MIDI controllers when loading a project #4883
Add CLI flag to disconnect all MIDI controllers when loading a project #4883
Conversation
The code looks fine. However, maybe we should add an export option that will not save MIDI connections to the file in first place? If that was your intention, I could try to implement that in the next following days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me, however, look on my comment please.
Hi, thanks for the feedback! I also think that an export option to omit the MIDI connections would be a cleaner solution. I hesitated before sending this PR because my solution felt a bit naive and hacky. If you have some time to look into it, I welcome your help in implementing this export option. |
Update: I have a working POC for a save dialog with a "discard MIDI connections" option. I'll polish and finish it in the next following days (hopefully tomorrow) |
Update: I've opened a PR at #5021; feel free to test it and report back. |
Hi! Just tested the master branch with all of your merged commits. It works very well. Closing this PR because the new save option makes it irrelevant. Many thanks, P. |
This is a redo of #4874, using master as base branch.
==
Hi!
Consider this PR as a request for comment, as this is my first attempt at hacking on LMMS.
This introduces a CLI flag (--disconnect-midi-controllers) used to disconnect all MIDI inputs from instrument tracks, as well as all MIDI controllers from instrument, FX and other global/song parameters. Other user controllers should be left untouched.
In and of itself, I find it useful to have a quick way to remove all midi connections from an existing project. For example, consider moving a project that has an extensive MIDI configuration for a specific hardware controller, over to another type of hardware controller. As I understand it, the current workflow would require disconnecting each individual controller mapping, one by one.
Also, it could be thought of as a quick fix for the following issues:
#4385
#2625
#193
Is this idea of any interest to anyone else?
If so, I understand that this is probably a naive approach and would welcome your feedback!
Many thanks!