Fix lost control links in copied automation patterns #4723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hack should be removed once the automation system gets fixed.
jasp00
reviewed
Dec 11, 2018
|
Possible regression with projects which single kind of parametr from multiple tracks connected to one automation track. For further checking. |
Draft
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
This hack should be removed once the automation system gets fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I said in #3781, I decided to work around the bug temporarily, at least in
stable-1.2. I believe we can fix underlying issues as well, but the required change is too large for stable releases.I think the ultimate solution is to decouple journaling and automation(see #3781 (comment)). I'll create a new issue to keep track on it once this PR gets merged.
Fixes #3781, fixes #3359.