Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake warning #4002

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Fix CMake warning #4002

merged 1 commit into from
Nov 22, 2017

Conversation

zapashcanon
Copy link
Contributor

Hi,

Fix #3985.

tresf
tresf reviewed Nov 22, 2017
View reviewed changes
CMakeLists.txt
@@ -8,7 +8,7 @@ IF(COMMAND CMAKE_POLICY)
CMAKE_POLICY(SET CMP0005 NEW)
CMAKE_POLICY(SET CMP0003 NEW)
IF (CMAKE_MAJOR_VERSION GREATER 2)
CMAKE_POLICY(SET CMP0026 OLD)
CMAKE_POLICY(SET CMP0026 NEW)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove it entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea... maybe @lukas-w can tell. I don't know anything about cmake, I just opened this PR because in #3985 @lukas-w said it was safe to set it to NEW while remove the warning.

@tresf
Copy link
Member

tresf commented Nov 22, 2017

The documentation states:

CMake version 3.0.2 warns when the policy is not set and uses OLD behavior.

So until we mandate 3.0.3, we need to specify it. Merging.

@tresf tresf merged commit 79e4775 into LMMS:master Nov 22, 2017
@PhysSong
Copy link
Member

PhysSong commented Nov 22, 2017 •
edited
Loading

lmms/CMakeLists.txt

Line 503 in 55076d0

GET_TARGET_PROPERTY(BIN2RES bin2res LOCATION)

CMP0026 is set to old because of this. And this was dropped in master via #1800 #1891,
Since LMMS requires CMake>=2.8.7, we may replace that to a syntax introduced in CMake 2.8 safely(on stable-1.2).

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@zapashcanon @tresf
Fix CMake warning (LMMS#4002)
fbbcd2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tresf tresf tresf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zapashcanon @tresf @PhysSong