Enable sample track recording

[Reflexe]

Download links for testing:

here.

many thanks to @tresf!

Progress

• Support capture in major interfaces:
  • JACK
  • PulseAudio
  • SDL
• Make recording work.
• Make recording usable for humans
  • Recording should record into a new TCO in the track or tracks that has been marked as record.
    • If no track was marked, it shall create a new track and mark it as record.
  • (Optional) Leave a way to record into a specific TCO (the current behaviour).
    • (Optional) Change the color of a TCO that has been set as record.
  • (Need to decide about the correct behaviour) Record according to another sample track: start and stop according to it.
  • Add per sample track audio channel modifiers (e.g. solo right, right both).
  • Hide the regular record button on the song editor.

Issues

• JACK does not connect lmms to the system input by default.
• Sometimes with SDL, a few seconds last does not get captured by lmms. (most of the times)
• For some reason, choosing a global record channel does not work correctly.
  Closes Sample track standalone recorder #3943

[gi0e5b06]

1. Great. Looks good for me.
   I would merge the Jack part so we can test.

2. Please add Alsa.

3. While you're working on these files, could you change the printf() to qWarning()/qCritical() ?
   Not urgent but it has do be done anyway.

[lukas-w]

While you're working on these files, could you change the printf() to qWarning()/qCritical() ?

No, this has nothing to do with this PR. Don't encourage people to do PRs the way you do them.

[qnebra]

In my case compiler got this:

/home/lukasz/lmms/compile/lmms/src/core/audio/AudioSdl.cpp: In member function ‘void AudioSdl::sdlInputAudioCallback(Uint8*, int)’:
/home/lukasz/lmms/compile/lmms/src/core/audio/AudioSdl.cpp:312:30: error: no matching function for call to ‘Mixer::pushInputFrames(sample_t (&)[2], fpp_t&, bool)’
true / applyGain */);

When lmms is compiled with your patch.

[BaraMGB]

I have tested this for ubuntu/Jack. I can record my voice in LMMS 🎉. That's great. I found some issues with the sample track resize from left, which makes no sense in an empty or fresh recorded tco. It should be set to 0 in this case.

[Reflexe]

@qnebra, My bad. I forgot to commit some files.

[Reflexe]

@BaraMGB I think I've fixed the issue with resizing from the left. Can you test it again please?

[BaraMGB]

Okay, tested. Works.

Next problems:

1. When I start the recording in the middle of the TCO:
   
   The recorded sample moved to the beginning of the TCO:
   

2. Recording in a loop doesn't work at all. When the Playhead moves back to the beginning of the loop, the recording stops and goes into the play mode.

3. We should find a way for the user to choose the channel(s). When I want to record my voice I use only the left channel of my interface. But in the current implementation I have my voice only in the left speaker.

[Reflexe]

Current issues:

• Record button does not work (Press record, press play)
• Loops don't work more than once (See @BaraMGB's comment)
• Problem with record not triggered:
  • Create a track, start recording from in the middle.
  • Now rerecord it from the start.
  • The result: The track would not get recorded until it reached the previous recording (Thanks to @BaraMGB)

[BaraMGB]

Here is a little bug, yet. When you recording start in the middle of the TCO you add a startTimeOffset() now. This is correct. But now: If you wanna record in this TCO the recording don't start at the beginning of the TCO. The recording starts only if the Playhead reaches the start+startTimeOffset() position.

I hope you understand me.

[Reflexe]

The last one has been solved (You just can't resize a track while recording).
I will check the two other ones in the next few days.

[PhysSong]

To be clear, I mean horizontal resizing(Shift + click and drag) of the track.

[Reflexe]

Oh. You're right. That does crash lmms for me.

…

On Sun, Aug 5, 2018 at 10:52 PM Hyunjin Song ***@***.***> wrote: To be clear, I mean horizontal resizing(Shift + click and drag) of the track. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3947 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVzDKBcsmbX7QK4ySzqV3ndGLHSYKypdks5uN9mTgaJpZM4QT_0a> .

[Reflexe]

I'm closing it for the a new feature/recording branch.