Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku update #3399

Merged
merged 3 commits into from
Mar 4, 2017
Merged

Haiku update #3399

merged 3 commits into from
Mar 4, 2017

Conversation

korli
Copy link
Contributor

@korli korli commented Mar 4, 2017

The first commit from waddlesplash allows to run as root.
The two others commits fix the build on Haiku, though the one with unistd.h isn't specific to Haiku.

@tresf
Copy link
Member

tresf commented Mar 4, 2017

Why would you want to run as root?

Also, we have an override flag that can be used, does it not work?

@korli
Copy link
Contributor Author

korli commented Mar 4, 2017

Running as root is the default on Haiku. I can remove that commit if you prefer.

@tresf
Copy link
Member

tresf commented Mar 4, 2017

If that is the norm, OK, then people can run it by default, it is just strange to read as a Linux/Unix user.

@korli
Copy link
Contributor Author

korli commented Mar 4, 2017

@waddlesplash your opinion on the "Allow running as root on Haiku." commit?

@waddlesplash
Copy link
Contributor

@tresf Haiku has POSIX multiuser, but the GUI all runs as root for BeOS compatibility. That won't change till after R1, most likely.

So keeping that change in there makes sense to me.

@tresf
Copy link
Member

tresf commented Mar 4, 2017

So keeping that change in there makes sense to me.

👍

@tresf
Copy link
Member

tresf commented Mar 4, 2017

@korli for consistency can we switch the statement to defined(LMMS_BUILD_HAIKU)

https://github.com/LMMS/lmms/blob/master/include/lmms_math.h#L37

@korli
Copy link
Contributor Author

korli commented Mar 4, 2017

It's now updated.

@tresf
Copy link
Member

tresf commented Mar 4, 2017

It's now updated.

Thanks. Will merge once Travis succeeds.

@tresf tresf merged commit 80c5b7d into LMMS:master Mar 4, 2017
PaulBatchelor pushed a commit to PaulBatchelor/lmms that referenced this pull request Mar 5, 2017
* Allow running as root on Haiku.
* include unistd.h for ::read and ::write.
* Link libnetwork on Haiku.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Allow running as root on Haiku.
* include unistd.h for ::read and ::write.
* Link libnetwork on Haiku.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants