-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku update #3399
Haiku update #3399
Conversation
Why would you want to run as root? Also, we have an override flag that can be used, does it not work? |
Running as root is the default on Haiku. I can remove that commit if you prefer. |
If that is the norm, OK, then people can run it by default, it is just strange to read as a Linux/Unix user. |
@waddlesplash your opinion on the "Allow running as root on Haiku." commit? |
@tresf Haiku has POSIX multiuser, but the GUI all runs as root for BeOS compatibility. That won't change till after R1, most likely. So keeping that change in there makes sense to me. |
👍 |
@korli for consistency can we switch the statement to https://github.com/LMMS/lmms/blob/master/include/lmms_math.h#L37 |
It's now updated. |
Thanks. Will merge once Travis succeeds. |
* Allow running as root on Haiku. * include unistd.h for ::read and ::write. * Link libnetwork on Haiku.
* Allow running as root on Haiku. * include unistd.h for ::read and ::write. * Link libnetwork on Haiku.
The first commit from waddlesplash allows to run as root.
The two others commits fix the build on Haiku, though the one with unistd.h isn't specific to Haiku.