Fix building on older Apple versions #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tresf
force-pushed
the
master
branch
2 times, most recently
from
39eb3e1 to
c088488
Compare
Adds libc++ to CXX flags Fixes macdeployqt on Qt5 Also fixes zynaddsubfx linking on Mac
Instead of defaulting to Qt 5.6+ per LMMS#2862
|
Travis passing. Changes benign. Merging. Side note... if Qt 5.6 ever receives a patch to |
Closed
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Fix building on older Apple versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We package our Apple installers from older OS X builds as to offer backwards compatibility with different OS X versions.
The 1.1 branch was built on OS X 10.7 which currently supports 10.11, 10.10, 10.9, 10.8, 10.7, 10.6.
The 1.2 branch added some newer features forcing us to build on 10.8, but unfortunately dropping support for 10.6.
This PR:
libc++to Apple CXX flags, needed since ac67f2amacdeployqton Qt5, prefers Qt5.5 due toQTBUG-53533RemoteZynAddSubFXZynAddSubFX, since it no longer crashes the software (warning, it still doesn't work, see ZynAddSubFX "Show GUI" broken (Apple) #703)