Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort effects in dialog #2836

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Sort effects in dialog #2836

merged 1 commit into from
Jun 16, 2016

Conversation

jasp00
Copy link
Member

@jasp00 jasp00 commented Jun 11, 2016

This fixes #2834.

@jasp00
Copy link
Member Author

jasp00 commented Jun 11, 2016

Entries are sorted by display name. Example:

Amplifier
LADSPA: 3 Band EQ
Multitap Echo

@tresf
Copy link
Member

tresf commented Jun 11, 2016

Can we abolish LADSPA and VST prefixes while we're at it? What worth does that have?

@DeRobyJ
Copy link
Contributor

DeRobyJ commented Jun 11, 2016

I think they are useful. It's just an opinion.
Having them lets you see what lmms sees in the vst folder, for example.

@mikobuntu
Copy link
Contributor

mikobuntu commented Jun 11, 2016

I think the best way to approach this would be to have lists e.g Native , LADSPA , VST .
Why not even have these collapsible like in the browser dialogue?

@tresf
Copy link
Member

tresf commented Jun 11, 2016

If we like em, make the type a column in a sortable table. Alphabetically, they cause a problem.

In regards to grouping like the file browser, please no.

@grejppi
Copy link
Contributor

grejppi commented Jun 11, 2016

Can we abolish LADSPA and VST prefixes while we're at it? What worth does that have?

FWIW #2616 will make them redundant with only an External prefix, which would be even less useful.

@jasp00
Copy link
Member Author

jasp00 commented Jun 15, 2016

Effects are now sorted with a sortable table.

@tresf
Copy link
Member

tresf commented Jun 15, 2016

@jasp00 at a glance, this seems to work well.

Pardon the screenshot, the font contrast will be filed as a separate issue.

screen shot 2016-06-14 at 9 59 53 pm

@jasp00 jasp00 merged commit b8bfe96 into LMMS:master Jun 16, 2016
@jasp00 jasp00 deleted the sort-eff branch June 16, 2016 19:35
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants