Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Main Window before loading/importing project #2555

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

zonkmachine
Copy link
Member

Fixes #2424

I didn't see all of the behaviours mentioned in issue #2424 though.

@zonkmachine zonkmachine changed the title Break out Open Recent Files to it's own 'if else{}' Move -> show() to before 'open recent' Feb 12, 2016
@zonkmachine zonkmachine reopened this Feb 12, 2016
@zonkmachine zonkmachine force-pushed the recentfilebug branch 2 times, most recently from 30b29bd to 5773799 Compare February 13, 2016 23:33
@zonkmachine zonkmachine changed the title Move -> show() to before 'open recent' Show Main Window befor loading/importing project Feb 13, 2016
@zonkmachine zonkmachine changed the title Show Main Window befor loading/importing project Show Main Window before loading/importing project Feb 13, 2016
@zonkmachine
Copy link
Member Author

@tresf After the same issue with projects showing first after a resize also is affecting imported projects ( @michaelgregorius / comment here ), I've come to the conclusion that you need to show the Main Window first and then load/import. It works fine here but I don't know what problems could come from it. However, it doesn't seem to have been done consequently from the start as loading a project and creating a new one is essentially the same routine but still "show()" was done either before or after.

@zonkmachine zonkmachine added this to the 1.2.0 milestone Feb 18, 2016
@zonkmachine
Copy link
Member Author

Only testing here. I'd like to get this merged soon.

@zonkmachine
Copy link
Member Author

Should be safe...
🚂 🚋

zonkmachine added a commit that referenced this pull request Feb 19, 2016
Show Main Window before loading/importing project
@zonkmachine zonkmachine merged commit 95b0ea2 into LMMS:master Feb 19, 2016
@zonkmachine zonkmachine deleted the recentfilebug branch February 19, 2016 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants