Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctrl+shift+a to deselect all notes in piano roll (#1488) #1963

Merged
merged 1 commit into from
Apr 16, 2015

Conversation

Wallacoloo
Copy link
Member

Should be self-explanatory.

It is somewhat picky about the behavior though. If you press ctrl+shift+a, all notes are properly deselected, but if you release shift before releasing either ctrl or a, then the ctrl+a shortcut will activate and all the notes will be reselected. In practice, I think most people tend to release the modifiers before the alphabet keys, and especially ctrl before shift, so I don't think this is a big deal.

@tresf
Copy link
Member

tresf commented Apr 16, 2015

@Wallacoloo just tested this in Chrome, CTRL + SHIFT + A, Release SHIFT, Whole page gets selected. I was skeptical, but this behavior seems to be correct, nice work.

tresf added a commit that referenced this pull request Apr 16, 2015
Add ctrl+shift+a to deselect all notes in piano roll (#1488)
@tresf tresf merged commit 49dccf5 into LMMS:master Apr 16, 2015
@Wallacoloo Wallacoloo mentioned this pull request Apr 16, 2015
6 tasks
@Wallacoloo Wallacoloo deleted the pianorolldeselect branch April 16, 2015 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants