Use rounded rectangles to draw notes #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can merge this, but again it's likely it'll get all overwritten with the CSS implementation... |
diizy
added a commit
that referenced
this pull request
Dec 26, 2014
Use rounded rectangles to draw notes
|
Thanks! I know, but at least it's already looking good on master : ) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the drawing method of the notes using a rounded rectangle, it is simpler and (at least for me) looks better.
Screenshot containing notes with different lengths, volumes and panning:
As @diizy pointed out on #64 this will be refactored into a collection of views instead of drawing the notes, but at least this is an improvement for the time being until it gets implemented. (I wanted to make it myself but I was having too much trouble).