Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: piano-roll cursor display glitch #572

Closed
wkwrd opened this issue Apr 6, 2014 · 14 comments
Closed

Issue: piano-roll cursor display glitch #572

wkwrd opened this issue Apr 6, 2014 · 14 comments

Comments

@wkwrd
Copy link

wkwrd commented Apr 6, 2014

As per the attached screenshot shown,
giltchy

OS: Win7 SP1(x64)

@wkwrd wkwrd changed the title Issue: piano-roll cursor redraw display glitch Issue: piano-roll cursor display glitch Apr 6, 2014
@DeRobyJ
Copy link
Contributor

DeRobyJ commented Apr 6, 2014

Please go to Edit > Setting > Folders.
Delete the theme folder: it will automatically set to the right one.

OR
Uninstal all the versions of LMMS you have, then install 1.0

(You are using a 0.4. theme on 1.0)

@eagles051387
Copy link

I think we have a bit of a bug with the themes. Is it possible that on
upgrade if there was a previous version already installed it uninstalls it
removes the theme directory then installs the new version in this case 1.0

On Sun, Apr 6, 2014 at 5:39 PM, DeRobyJ [email protected] wrote:

Please go to Setting > folders.
Delete the theme folder, it will automatically set to the right one.

OR
Uninstal all the versions of LMMS you have, then install 1.0

(You are using a 0.4. theme on 1.0)

Reply to this email directly or view it on GitHubhttps://github.com//issues/572#issuecomment-39671498
.

Jonathan Aquilina

@DeRobyJ
Copy link
Contributor

DeRobyJ commented Apr 6, 2014

Some users mey not want the old version uninstalled.

Maybe the program should detect that the theme is old, then reset it if it finds a <1.0 one.

@BaraMGB
Copy link
Contributor

BaraMGB commented Apr 6, 2014

The old "style.css" background color expect hexadecimal values. The new one cause this bug if hex values in the arguments.

@Sti2nd
Copy link
Contributor

Sti2nd commented Apr 6, 2014

As of now themes and settings is shared between the different versions. What if the correct default theme was detected by using the fact that it is in the same folder as LMMS X.X.X. Only on install though, it is great not having to duplicate the themes for different LMMS versions.

@diizy
Copy link
Contributor

diizy commented Apr 6, 2014

On 04/07/2014 12:17 AM, Stian Jørgensrud wrote:

As of now themes and settings is shared between the different
versions. What if the correct default theme was detected by using the
fact that it is in the same folder as LMMS X.X.X.

No, settings are user-specific so they are in the user's home directory.

@Sti2nd
Copy link
Contributor

Sti2nd commented Apr 7, 2014

Ok then, but it means the settings are used by all LMMS programs. It is perhaps better that the new downloaded versions automatically use the theme in their folder? Then the user must change theme again if he is using older versions, but he would understand that, wouldn't he?

@diizy
Copy link
Contributor

diizy commented Apr 7, 2014

On 04/07/2014 01:27 PM, Stian Jørgensrud wrote:

Ok then, but it means the settings are used by all LMMS programs. It
is perhaps better that the new downloaded versions automatically use
the theme in their folder? Then the user must change theme again if he
is using older versions, but he would understand that, wouldn't he?

Something like that would be up to packagers to implement. Packagers can
easily write a script that finds the settings file and removes the
setting for "theme directory".

Of course that doesn't help windows users, who just get the binaries
compiled by Toby. However, since Windows doesn't really deal well with
parallel installations of LMMS in any case, and it is highly recommended
for windows users to just stick to one LMMS installation per Windows OS,
I don't see this as much of an issue.

Furthermore, I don't think we should go out of our way to enable support
for multiple LMMS installations. If we go down that path, it'll open the
doors for all kinds of possible future incompatibility issues and
weirdnesses that the developers then have to deal with it - which takes
time away from LMMS development, improvements and new features. Most
other software projects don't provide official support for parallel
versions either, so I don't think this is much of a problem.

@diizy
Copy link
Contributor

diizy commented Apr 12, 2014

Closing as not a bug

@Sti2nd
Copy link
Contributor

Sti2nd commented Sep 5, 2014

Not a bug.... well... we have like a hundred of "bug reports" on this now...

@Sti2nd
Copy link
Contributor

Sti2nd commented Sep 5, 2014

Because I am so tired of telling every user over an over about this, I did what I have the power of, writing it on the wiki in the Frequently Asked Questions http://lmms.sourceforge.net/wiki/index.php/User_FAQ

I could also put in on the front page of the wiki, Facebook and G+, but I have already mentioned it on FB and G+ when the last release went live.

@tobydox
Copy link
Member

tobydox commented Sep 6, 2014

@diizy: what about adding version information to themes and a check at startup which checks compatibility of the theme set by the user? If the theme is too old, we could revert to the correct default theme.

@diizy
Copy link
Contributor

diizy commented Sep 6, 2014

On 09/06/2014 08:29 PM, Tobias Doerffel wrote:

@diizy https://github.com/diizy: what about adding version
information to themes and a check at startup which checks
compatibility of the theme set by the user? If the theme is too old,
we could revert to the correct default theme.

I would support this idea, along with adding some other metadata to
themes as well - this could also go towards helping us build a better UI
for theme selection.

A simple metadata file with an easy, human-readable format, something
like this maybe:

author = Example Name
email = [email protected]
copyright = CC BY-SA
name = Example LMMS Theme
version = 1.1

@Sti2nd
Copy link
Contributor

Sti2nd commented Sep 6, 2014

SIDENOTE: Having that information available for themes made me think about how needed copyright written as a part of regular project files is. The second most asked question after the glitch problem, is: "Can I remix Capdan/Skiessi/Zakarra?". The lsp could instead fetch the data from the project file itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants