Select, copy, and paste in automation track #5157

eland1 · 2019-08-28T11:46:02Z

it would be amazing if you could select, copy and paste in the automation track. it is also nice if you can place two points right under eachother. i think it becomes a sidechain dream.

Below added by @Spekular

A complete implementation of group selection in song editor should also allow deletion of the selected points.

Spekular · 2019-08-28T15:25:18Z

Selection is a duplicate of of #4602.

musikBear · 2019-08-29T15:22:30Z

place two points right under eachother.

@eland1 In respect to that, you can just set Q -quantification to highest value. You will never be able to hear the difference between 'same value' and a distance of 1/192. That is not audible

ghost · 2019-09-05T15:51:30Z

I was looking into implementing this and found that most of the code is already there, it needs some modifications and some extra code. Is anyone working on this? Else I will give it a try :-)

BaraMGB · 2019-09-05T18:42:39Z

@cyberdevilnl Actually I am on it. At first I want to implement the ability to have more than one control point per time key. I suppose you want to implement select, copy paste?

ghost · 2019-09-06T14:13:21Z

@BaraMGB all right that's awesome! Yes I was talking about the select, copy and paste. Let me know if I can help :-)

tecknixia · 2019-10-19T01:53:25Z

I've been rewriting the mouse functions for clarity and I decided I might as well look into this, so in order to figure out how it works, I wrote down something like a map of the process that's involved. I figured it might help.

AutomationEditorWindow::AutomationEditorWindow

	DropToolBar *editActionsToolBar = addDropToolBarToTop(tr("Edit actions"));
	ActionGroup* editModeGroup = new ActionGroup(this);

	QAction* drawAction = editModeGroup->addAction(embed::getIconPixmap("edit_draw"),
		tr("Draw mode (Shift+D)"));
	QAction* eraseAction = editModeGroup->addAction(embed::getIconPixmap("edit_erase"),
		tr("Erase mode (Shift+E)"));

	// these next two lines are in a different format, so I changed them to match the others
	QAction* selectAction = editModeGroup->addAction(embed::getIconPixmap("edit_select"),
		tr("Select: Disabled"));
	QAction* moveAction = editModeGroup->addAction(embed::getIconPixmap("edit_move"),
		tr("Move: Disabled"));

That is just defining them, so order doesn't matter (the above)

Here is my map (below):

connect(editModeGroup, SIGNAL(triggered(int)), m_editor, SLOT(setEditMode(int)));
	-> QAction
		-> AutomationEditor::setEditMode(int mode)
			-> setEditMode((AutomationEditor::EditModes) mode);
				-> AutomationEditor::EditModes

				- (enum) DRAW, ERASE, SELECT, MOVE (in header file)
				- the order of EditModes in header file
				 determines which action is triggered
				- if you put 'erase' in front of 'draw',
				the draw button will erase, and erase button will draw

					-> m_editMode

		// there's two of them?
		-> AutomationEditor::setEditMode(AutomationEditor::EditModes mode)
			-> m_editMode = mode;
			-> AutomationEditor::removeSelection
			-> AutomationEditor::getSelectedValues

The way the code works is confusing to me, but essentially it seems to me that it just takes the signal of the buttons on the toolbar and puts m_editMode into the associated mode.

	editActionsToolBar->addAction(drawAction);
	editActionsToolBar->addAction(eraseAction);
	editActionsToolBar->addAction(selectAction);
	editActionsToolBar->addAction(moveAction);

The order of these (above) determines the order of the buttons on the toolbar.
The order does not affect the functionality

switch( m_editMode )
{
	case DRAW:
		if( m_mouseDownRight )
		{
			cursor = s_toolErase;
		}
		else if( m_action == MOVE_VALUE )
		{
			cursor = s_toolMove;
		}
		else
		{
			cursor = s_toolDraw;
		}

		break;
	case ERASE: cursor = s_toolErase; break;
	case SELECT: cursor = s_toolSelect; break;
	case MOVE: cursor = s_toolMove; break;
}
QPoint mousePosition = mapFromGlobal( QCursor::pos() );
	if( cursor != NULL && mousePosition.y() > TOP_MARGIN + SCROLLBAR_SIZE)
	{
		p.drawPixmap( mousePosition + QPoint( 8, 8 ), *cursor );
	}

And that just changes the cursor according to the mode.

From there my guess it's it's just a matter of m_editMode states within the code.

I'm thinking about combining a few Automation Editor issues, as I've talked about here:

Automation: points deleted while moving other points can be restored abnormally
#4671

Edit: I created a branch (forget this one... see below)
https://github.com/tecknixia/lmms/tree/automationProject

Edit: New replacement for the above (see this one, not the above)
https://github.com/tecknixia/lmms/tree/autoSelectCopyPaste

Spekular · 2019-10-20T08:36:34Z

Personally I think this should be two separate issues, one for group selection and one for placing points at the same time. However, given the huge number of open issues I believe they can stay as one for now. Perhaps if one part is implemented and the other remains, the remaining one can be split into a new issue and this can be closed.

tecknixia · 2019-10-20T15:13:42Z

In the branch I'm working on [above] I've managed to get select and move working, but I'm running into three issues that seem to be related.

Issue Automation scroll limited by song editor #5254 - Select All - only selects the length of measures in Song Editor

Issue Automation: points deleted while moving other points can be restored abnormally #4671 - [Maybe related:] while moving a selection, some points randomly disappear.

I'm looking into this.

Issue #??? - actually I couldn't find an issue for this one... but the timeline position bar is broken.

This will be needed for pasting into the editor at the correct position. It doesn't move when play is pressed, so I imagine the code wasn't completed. I'll be looking into this too.

tecknixia · 2019-10-20T15:50:47Z

@Spekular

The more I play with this issue of moving a selection, the more it seems like the random points are disappearing as they move to a position on top of one another. When I read what you said, I agreed about the separate issues, but then I noticed this. It seems like the issues may be related after all.

Edit:

I just noticed that if you pass the selection quickly over or under the other points, they remain, but if you slowly drag the selection, it deletes all the other points.

Spekular · 2019-10-20T16:11:29Z

If two land on each other at least one will be deleted because we currently don't support several points on top of each other. Points at the same position is still a separate issue IMO, as you can implement (and benefit from) one without the other (and this applies both ways).

…

On Sun, Oct 20, 2019, 17:50 tecknixia ***@***.***> wrote: @Spekular <https://github.com/Spekular> The more I play with this issue of moving a selection, the more it seems like the random points are disappearing as they move to a position on top of one another. When I read what you said, I agreed about the separate issues, but then I noticed this. It seems like the issues may be related after all. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5157?email_source=notifications&email_token=ACEBLGTRXUY3AH72JSOE5ELQPR453A5CNFSM4IREGMOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYNDWY#issuecomment-544264667>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEBLGVJWX3WBNN5UFZQGQ3QPR453ANCNFSM4IREGMOA> .

tecknixia · 2019-10-20T16:11:51Z

@Spekular

After thinking about it some more, if points are getting deleted because they're on top of each other, than allowing them to co-exist on the same tick would probably fix that issue.

However, this might involve some strategy in how the mouse functions run. Even if the issues are related, I think you're right, it seems to deserve it's own issue because of the depth of the issue. This issue can then be mentioned by that one.

tecknixia · 2019-10-21T03:17:24Z

Just realized... if it works when dragging a single point, why can't it work for multiple points?

I'll have to take a closer look, it seems likely possible to fix this without having to worry about the issue of two points occupying the same x position.

Thoughts about moving a selection have been moved here:

Move A Selection

So, the problem is that the points are being moved and placed with each mouse move, instead of being dragged. I tried using setDragValue, but it seems to condense all the points in the selection to a single point. So, "how to apply a drag value to multiple points?" seems to be the next question.

tecknixia · 2019-11-09T02:57:45Z

I had to redo some things, so I created a new branch for this with cleaner commits.
https://github.com/tecknixia/lmms/commits/autoSelectCopyPaste

Improvements:

Select, cut, and copy all seem to be working now
Including "select all"
Move will move points, but still needs work (see below)
Paste will paste data, but wrong position (see below)
Delete will remove selected points
Escape will cancel selection (currently only in select mode)
Fixed broken toolbar buttons, including right-click mode switching
Made the selection box transparent
Enabled the ability to scroll while selecting

Also in this branch:

Automation point adjustment with wheel scroll and double click included (Automation Editor point fine tuning with wheel scroll #5291 and Automation Editor point fine tuning with double click #5292 )
Point adjustment PRs also contain a fix for Automation Editor Nodes Don't Always Delete #3301
Cancel dragging by click right mouse button Automation point drag cancel with right click #5316 (fixes Automation: points deleted while moving other points can be restored abnormally #4671)
Cancel drag when drawing lines Automation Editor - Prevent dragging last point when drawing line #5315 (fixes Automation Editor - draw line function selects last point drawn for a drag #4040)

Some issues:

Move: still deletes other points
Paste: not synced with time line position indicator
Paste: may be limited by Song Editor Automation scroll limited by song editor #5254 (untested)
Scroll while selecting: won't scroll to the right when window is maximized
Scroll while selecting: scroll limited by Song Editor Automation scroll limited by song editor #5254
Select All: selection limited by Song Editor Automation scroll limited by song editor #5254

I'll probably also be looking into a few other Automation Editor issues.

Phantom automation Phantom automation #4628
Possibly related...? Bugs with automation (when cloning an automated instrument or undoing the deletion of the automation track) #5374

#4877

tecknixia · 2019-11-10T03:21:12Z

The main problem seems to be... each time setDragValue is run:

it's only being passed the coordinates of one point
it deletes the point at that time position
takes "a picture" of the other points on the map
sets m_dragging to true, which allows skipping of the above
applies the picture of the points not being dragged (each time it runs) back onto the map
then each time returns this->putValue(time, value, quantPos, controlKey)

For the basic idea of how to do this, it seems like the main thing that needs to be done is to take note of all the positions of the multiple points being moved, then delete those values from the map, and then copy the map of the others, so that you have a copy to place back onto the map each time a move is made.

Edit: I just realized there's already functionality like this for moving notes in piano roll.

PianoRoll::getSelectedNotes
PianoRoll::dragNotes
PianoRoll::copyToClipboard
PianoRoll::copySelectedNotes
PianoRoll::cutSelectedNotes
PianoRoll::pasteNotes
PianoRoll::deleteSelectedNotes

I think it would be a good idea for the core logic of automation points to remain consistent with the core logic of notes. Notes can already be selected, moved, copied, pasted, etc.

Notes have a class of their own, and the moving of multiple selected notes involves the use of a "NoteVector". I think the same could be done for automation points and a "PointVector". I did get started on the class files, although instead of talking about it here, this modification seems large enough to deserve it's own issue.

I'm still new to C++, and it's still a bit hard for me to read and follow the code. I'm looking into this, but I could use guidance, or assistance, from someone who is familiar with notes, Piano Roll, and the Song Editor.

tecknixia:autoSelectCopyPaste

I'm documenting my understanding of the code here: Automation Editor

SecondFlight changed the title ~~select copy and paste in automation track~~ Select, copy, and paste in automation track Aug 28, 2019

SecondFlight added the enhancement label Aug 28, 2019

BaraMGB self-assigned this Sep 10, 2019

tecknixia mentioned this issue Oct 18, 2019

Automation: points deleted while moving other points can be restored abnormally #4671

Open

Spekular mentioned this issue Oct 20, 2019

Delete the selection in automation track #5259

Closed

BaraMGB removed their assignment Nov 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Select, copy, and paste in automation track #5157

Select, copy, and paste in automation track #5157

eland1 commented Aug 28, 2019 •

edited by Spekular

Loading

Spekular commented Aug 28, 2019

musikBear commented Aug 29, 2019

ghost commented Sep 5, 2019

BaraMGB commented Sep 5, 2019

ghost commented Sep 6, 2019

tecknixia commented Oct 19, 2019 •

edited

Loading

Spekular commented Oct 20, 2019

tecknixia commented Oct 20, 2019

tecknixia commented Oct 20, 2019 •

edited

Loading

Spekular commented Oct 20, 2019 via email

tecknixia commented Oct 20, 2019

tecknixia commented Oct 21, 2019 •

edited

Loading

tecknixia commented Nov 9, 2019 •

edited

Loading

tecknixia commented Nov 10, 2019 •

edited

Loading

Select, copy, and paste in automation track #5157

Select, copy, and paste in automation track #5157

Comments

eland1 commented Aug 28, 2019 • edited by Spekular Loading

Spekular commented Aug 28, 2019

musikBear commented Aug 29, 2019

ghost commented Sep 5, 2019

BaraMGB commented Sep 5, 2019

ghost commented Sep 6, 2019

tecknixia commented Oct 19, 2019 • edited Loading

Spekular commented Oct 20, 2019

tecknixia commented Oct 20, 2019

tecknixia commented Oct 20, 2019 • edited Loading

Spekular commented Oct 20, 2019 via email

tecknixia commented Oct 20, 2019

tecknixia commented Oct 21, 2019 • edited Loading

tecknixia commented Nov 9, 2019 • edited Loading

tecknixia commented Nov 10, 2019 • edited Loading

eland1 commented Aug 28, 2019 •

edited by Spekular

Loading

tecknixia commented Oct 19, 2019 •

edited

Loading

tecknixia commented Oct 20, 2019 •

edited

Loading

tecknixia commented Oct 21, 2019 •

edited

Loading

tecknixia commented Nov 9, 2019 •

edited

Loading

tecknixia commented Nov 10, 2019 •

edited

Loading