-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gWCS instead of normal WCS for SJI #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
force-pushed
the
undo
branch
5 times, most recently
from
January 5, 2023 04:44
8cb0c99
to
9f7d8b5
Compare
This was referenced Jan 11, 2023
nabobalis
force-pushed
the
undo
branch
2 times, most recently
from
January 11, 2023 00:25
4c56bb9
to
9a0b449
Compare
nabobalis
changed the title
Use gWCS instead of normal WCS.
Use gWCS instead of normal WCS for SJI
Jan 11, 2023
nabobalis
force-pushed
the
undo
branch
2 times, most recently
from
January 14, 2023 00:07
c6a2eb3
to
a6a4af5
Compare
nabobalis
commented
Jun 6, 2023
nabobalis
commented
Jun 6, 2023
nabobalis
force-pushed
the
undo
branch
9 times, most recently
from
June 7, 2023 18:15
fa801d3
to
588d637
Compare
nabobalis
force-pushed
the
undo
branch
2 times, most recently
from
June 7, 2023 18:24
588d637
to
158d556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deal with the FITS WCS, I have switched to gWCS, this will allow me to undo all of changes I had to make in previous PRs.
raster gWCS will come in the future.
This also has the V34 changes.
TODO:
.time
is very slow and memory intensive. See_generate_world_coords
is slow and uses a lot of memory sunpy/ndcube#585 and Time to computeaxis_world_coords
scales poorly with dimensionality with off-diagonal elements in PCij sunpy/ndcube#554