Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evol/psr4 #36

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Evol/psr4 #36

merged 5 commits into from
Mar 23, 2023

Conversation

MadCat34
Copy link
Contributor

@MadCat34 MadCat34 commented Feb 11, 2023

Passe de PSR-0 à PSR-4

…k\MockObject\MockObject in docblock

Removed tests/bootstrap.php and tests/configuration.php.dist
@MadCat34
Copy link
Contributor Author

MadCat34 commented Feb 11, 2023

Plusieurs problèmes dans les tests unitaires :

  • code déprécié dans PHPUnit 10: cf Deprecate at() matcher sebastianbergmann/phpunit#4297
  • utilisation de chaines de caractères pour les noms de classe au lieu d'utiliser ::class
  • utilisation de array() au lieu de la syntaxe courte [ ] => préférence personnel
  • utilisation de ->will($this->returnValue(...)) au lieu de willReturrn(...);

A corriger dans cette PR ?


Some problems in unit tests:

  • some deprecated code that will be remove in PHPUnit 10 : cf Deprecate at() matcher sebastianbergmann/phpunit#4297 (fixed in this PR)
  • use strings for classname instead of ::classusage (not fixed in this PR)
  • use array() instead of short array [] (not fixed in this PR)
  • use ->will($this->returnValue(...)) instead of ->willReturn(...) (fixed in this PR)

@visto9259
Copy link
Member

@MadCat34 Merci. Je regarde le tout.
Thanks for the PR. I will take a look at it. I suggest that your write your comments in English. I am fluent in French but we are both part of a minority of people that can use French. Actually I assume that @matwright can also speak French... 😄

@MadCat34 MadCat34 marked this pull request as ready for review February 14, 2023 00:20
@matwright matwright merged commit 7d7e32c into LM-Commons:master Mar 23, 2023
@visto9259 visto9259 mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants