Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In login action, when the form is not valid, the controller redirects to login and the form error messages are lost #75

Closed
visto9259 opened this issue Apr 17, 2024 · 1 comment · Fixed by #88
Closed

In login action, when the form is not valid, the controller redirects to login and the form error messages are lost #75

visto9259 opened this issue Apr 17, 2024 · 1 comment · Fixed by #88
Labels
bug Something isn't working V3 To be fixed in version 3 V4 To be implemented in version 4

Comments

@visto9259
Copy link
Member

In the login action, when the form is not valid, the controller redirects to the login route. Therefore, any form validation errors are lost.

The controller should render the login view again with the validated form such that the errors are available for display by the login view.
@visto9259 visto9259 added the bug Something isn't working label Apr 17, 2024
@visto9259 visto9259 added V4 To be implemented in version 4 V3 To be fixed in version 3 labels Apr 17, 2024
@visto9259 visto9259 mentioned this issue Jun 18, 2024
Open
@visto9259 visto9259 modified the milestones: 4.0.0, 3.7.0 Jun 25, 2024
@visto9259
Copy link
Member Author

Fixed in v4.
Will be fixed in v3 as well

visto9259 added a commit to visto9259/LmcUser that referenced this issue Jun 26, 2024
@visto9259
To fix LM-Commons#75
71dd862 
Signed-off-by: Eric Richer [email protected] <[email protected]>
@visto9259 visto9259 mentioned this issue Jun 26, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in LmcUser Development Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working V3 To be fixed in version 3 V4 To be implemented in version 4
Projects
LmcUser Development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 75 visto9259/LmcUser
1 participant
@visto9259