Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site CI: report job status, check for exit codes, add machines and benchmarks #402

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

site CI: report job status, check for exit codes, add machines and benchmarks #402

wants to merge 10 commits into from

Conversation

slabasan
Copy link
Collaborator

@slabasan slabasan commented Oct 18, 2024 •
edited
Loading

Merge after #396. This PR extends CI support for site testing benchmarks.

  • draft status to toggle running of gitlab
  • reporting pass/fail status to github
  • testing new workflow with saxpy on tioga
  • kripke (gpu) on tioga
  • add site user @alecbcs
  • look at exit modifier in ramble

@slabasan slabasan added the ci Involving Project CI & Unit Tests label Oct 18, 2024
@slabasan slabasan changed the title ci: add local testing of modified benchmarks extended site CI support Oct 18, 2024
@slabasan slabasan added the WIP A work-in-progress not yet ready to commit label Oct 18, 2024
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 3 times, most recently from 886510d to 7559acf Compare October 22, 2024 23:45
@slabasan slabasan removed the WIP A work-in-progress not yet ready to commit label Oct 23, 2024
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 6 times, most recently from 08e9abb to f9c763d Compare October 30, 2024 20:49
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 5 times, most recently from c4f25e1 to 7db9e03 Compare November 2, 2024 02:59
@slabasan slabasan changed the title extended site CI support site CI: report job status, check for exit codes Nov 2, 2024
@slabasan slabasan changed the title site CI: report job status, check for exit codes site CI: report job status, check for exit codes, add machines and benchmarks Nov 2, 2024
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from 7db9e03 to 65e0a75 Compare November 2, 2024 16:02
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch 2 times, most recently from f0b9dea to 7991544 Compare November 13, 2024 21:29
@slabasan
Copy link
Collaborator Author

@pearce8 This one ready for merge

@slabasan slabasan enabled auto-merge (squash) November 13, 2024 21:53
@alecbcs alecbcs self-requested a review November 14, 2024 01:04
alecbcs
alecbcs requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@alecbcs alecbcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slabasan it looks like this pipeline is running too many jobs / reserving too many nodes on Tioga. We've been asked to pause or halt until we can limit the number of jobs.

@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from 951d2b7 to a8abf39 Compare November 15, 2024 03:08
@pearce8
Copy link
Collaborator

pearce8 commented Nov 19, 2024

@slabasan heads up: #440 is likely to get merged first, at which point we need to merge latest changes from develop, and update the ci script to use the binary variants.

@slabasan
report results to github
4045c79
@slabasan
add more jobs
22bcad3 
covering:
- new, old workflow
- tioga, ruby, dane
- kripke, saxpy
- openmp, rocm
@slabasan
add exit code modifier by default
002812a
@slabasan
add format flag to ramble analyze
0ce248f
@slabasan
add --always-print-foms flag to ramble on for current supported rambl…
e04a06b 
…e version

remove this flag when we bump the ramble version as it will be a default option
@slabasan
add command to check for exit codes
75fe41a 
- fail if any exit codes are non-zero
@slabasan
add benchpark service user
7421a98
@slabasan
update gitlab
70c2c7a 
- move from shell to batch runners
- workflow is interruptible, so new commits will cancel existing pipeline
@slabasan
update experiment init with new booleans
b7f28df
@slabasan slabasan force-pushed the add/site-ci-tests-more-features branch from a8abf39 to b7f28df Compare November 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecbcs alecbcs alecbcs requested changes

@pearce8 pearce8 Awaiting requested review from pearce8

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci Involving Project CI & Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slabasan @pearce8 @alecbcs