Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/debug db #72

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Features/debug db #72

merged 2 commits into from
Jun 17, 2024

Conversation

koparasy
Copy link
Member

@koparasy koparasy commented Jun 7, 2024

Allow HDF5 to store all data (including model predictions and UQ) to enable debugging.

@koparasy koparasy requested a review from lpottier June 7, 2024 18:49
Copy link
Collaborator

@lpottier lpottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Quick question @koparasy : if we have all HDF5 in a separate file, should we also move RMQ details into its own file?

@koparasy
Copy link
Member Author

It looks good to me. Quick question @koparasy : if we have all HDF5 in a separate file, should we also move RMQ details into its own file?

Yes we should. It is not a top priority though. The basedb file was getting pretty big to "handle". When we have modifications on RMQ we can push it on another file.

@koparasy koparasy force-pushed the features/debug-db branch from bb03ecf to bcfe2d9 Compare June 17, 2024 15:44
@koparasy koparasy force-pushed the features/debug-db branch from 1d0690e to 0be598c Compare June 17, 2024 18:55
@koparasy koparasy marked this pull request as ready for review June 17, 2024 18:55
@koparasy koparasy merged commit 2ff2160 into develop Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants