godl: only use git:// scheme as last option

[thaJeztah]

• relates to docs/daemon: replace deprecated '-g' option for '--data-root' docker/cli#3405 (comment)
• relates to [20.10] use GO_LDFLAGS instead of LDFLAGS to prevent inheriting unrelated options docker/cli#3514 (comment)

The git:// protocol is insecure (equivalent of http://), and GitHub has
deprecated support for this, see:
https://github.blog/2021-09-01-improving-git-protocol-security-github/

Which causes vendoring with vndr to fail:

2022/03/31 09:29:01 Download dependencies
2022/03/31 09:29:02 Starting whole vndr cycle because no package specified
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

This patch moves the git:// scheme to the end of the list of schemes to try,
so that https:// is used as default. I kept git:// in the list, to allow
it to be used for servers (other than GitHub) that still support it.

Signed-off-by: Sebastiaan van Stijn [email protected]

[thaJeztah]

Failure on windows looks unrelated (perhaps we need a longer timeout);

Running [D:\a\_temp\b148c182-c1f8-4d83-be8f-79f325b53237\golangci-lint-1.42.0-windows-amd64\golangci-lint run --out-format=github-actions --path-prefix=src/github.com/LK4D4/vndr] in [D:\a\vndr\vndr\src\github.com\LK4D4\vndr] ...
level=error msg="Running error: context loading failed: failed to load packages: timed out to load packages: context deadline exceeded"
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

Error: golangci-lint exit with code 4
Ran golangci-lint in 61363ms

[thaJeztah]

@LK4D4 PTAL 🤗 👋

[thaJeztah]

oh, fun! I just found that there was a replace rule in our vendor.conf (docker/cli#3516), so looks like it's actually not vndr that defaulted to trying the protocol, or only because of that one 😂

Guess this change in itself wouldn't hurt (to use it as last option instead of the first one)

[thaJeztah]

Thanks @LK4D4 ! (hope you're doing well! we should catch up!)