Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #371 #376

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fixes #371 #376

merged 2 commits into from
Jul 20, 2023

Conversation

LostAttractor
Copy link
Contributor

Fixes #371

发现箭头不居中为font-size: 1.75rem;属性所致,去除即恢复正常
所以给了个left: -0.875rem解决

image

不过虽然箭头是这样对齐了,但是这个div还是没对齐,鄙人不是做前端的不是很懂CSS,不过推测是因为居中的实现方法是left:50%,但我也不知道应该怎么居中好(
image

居中问题的话,通过在lower-container的css增加position: absolute;解决了,halo1的版本中是有这个修饰的

此外,我没有npm run build,我构建会失败

[vite]: Rollup failed to resolve import "APlayer" from "/home/lostattractor/Documents/GitHub/halo-theme-sakura/src/module/utils.ts".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
error during build:
Error: [vite]: Rollup failed to resolve import "APlayer" from "/home/lostattractor/Documents/GitHub/halo-theme-sakura/src/module/utils.ts".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
    at viteWarn (file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/vite/dist/node/chunks/dep-abb4f102.js:48051:27)
    at onRollupWarning (file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/vite/dist/node/chunks/dep-abb4f102.js:48083:9)
    at onwarn (file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/vite/dist/node/chunks/dep-abb4f102.js:47814:13)
    at file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/rollup/dist/es/shared/node-entry.js:24070:13
    at Object.logger [as onLog] (file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/rollup/dist/es/shared/node-entry.js:25742:9)
    at ModuleLoader.handleInvalidResolvedId (file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/rollup/dist/es/shared/node-entry.js:24656:26)
    at ModuleLoader.resolveDynamicImport (file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/rollup/dist/es/shared/node-entry.js:24714:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///home/lostattractor/Documents/GitHub/halo-theme-sakura/node_modules/rollup/dist/es/shared/node-entry.js:24601:32

根据提示在build.rollupOptions.external增加APlayerAPlayer/dist/APlayer.min.css?used后可以构建了但是构建出来的/assets/dist/就会没有aplayer的js和css,不知道正确应该是怎么构建的,请教一下,到时候我补上
此外,构建也可以加个ci(

@LIlGG
Copy link
Owner

LIlGG commented Jul 17, 2023

是否使用了 pnpm install 进行依赖包下载?后续会增加 ci 进行构建

@LIlGG
Copy link
Owner

LIlGG commented Jul 17, 2023

目前也缺少关于开发的文档,找机会我会补充一下。

@LostAttractor
Copy link
Contributor Author

是否使用了 pnpm install 进行依赖包下载?后续会增加 ci 进行构建

是的,npm和pnpm我都试了,都不行
不确定和我在用NixOS有没有什么关系,Nix的环境比较怪

src/css/common/components/screen/top-down.css Outdated Show resolved Hide resolved
src/css/common/outline/header/menu.css Show resolved Hide resolved
@LIlGG
Copy link
Owner

LIlGG commented Jul 19, 2023

我已经解决了 npm 构建失败的问题并增加了 github actions 进行 ci 构建,你可以重新拉取一下最新的代码。

@LIlGG
Copy link
Owner

LIlGG commented Jul 20, 2023

非常完美,它能够正常工作并且符合预期,感谢提供的 PR。

@LIlGG LIlGG merged commit 50c25aa into LIlGG:next Jul 20, 2023
@LostAttractor LostAttractor deleted the Fixes-371 branch July 22, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

主页元素不居中
2 participants