-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat: start using zod for schema validation and type definitions #660
Draft
FedericoAmura
wants to merge
33
commits into
master
Choose a base branch
from
feature/lit-3796-js-sdk-research-to-use-zod
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: feat: start using zod for schema validation and type definitions #660
FedericoAmura
wants to merge
33
commits into
master
from
feature/lit-3796-js-sdk-research-to-use-zod
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansonhkg
added
the
🚧 In Progress - Don’t Merge
pull request is still under active development and should not be merged into the main branch. It sig
label
Sep 29, 2024
…earch-to-use-zod # Conflicts: # yarn.lock
…to define leveraging the previous ones
…e-zod # Conflicts: # packages/constants/src/lib/constants/constants.ts # packages/types/src/lib/interfaces.ts
…htly improve its testing
…earch-to-use-zod # Conflicts: # packages/constants/src/lib/constants/constants.ts
…earch-to-use-zod # Conflicts: # packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts # packages/types/src/lib/ILitNodeClient.ts # packages/types/src/lib/interfaces.ts
…earch-to-use-zod # Conflicts: # typedoc.json # yarn.lock
FedericoAmura
commented
Nov 22, 2024
|
||
export const ExecuteJsResponseSchema = ExecuteJsResponseBaseSchema.extend({ | ||
success: z.boolean().optional(), | ||
response: z.union([z.string(), z.object({})]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO check if this is always a string, try to define a proper response type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🚧 In Progress - Don’t Merge
pull request is still under active development and should not be merged into the main branch. It sig
v8 | Naga
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR incorporates
zod
as the schema validation tool and derives types from thoseType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: