Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: start using zod for schema validation and type definitions #660

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

FedericoAmura
Copy link
Contributor

Description

This PR incorporates zod as the schema validation tool and derives types from those

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@FedericoAmura FedericoAmura self-assigned this Sep 27, 2024
@Ansonhkg Ansonhkg added the 🚧 In Progress - Don’t Merge pull request is still under active development and should not be merged into the main branch. It sig label Sep 29, 2024
Base automatically changed from staging/v7 to master November 19, 2024 23:05

export const ExecuteJsResponseSchema = ExecuteJsResponseBaseSchema.extend({
success: z.boolean().optional(),
response: z.union([z.string(), z.object({})]),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO check if this is always a string, try to define a proper response type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 In Progress - Don’t Merge pull request is still under active development and should not be merged into the main branch. It sig v8 | Naga
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants