[core] Refactor ui/src/services and remove uncommon getters in BaseShop #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haVincy
force-pushed
the
core/refactor-multi-chain-codes
branch
from
4d2e55b to
0121ef1
Compare
|
Test link - https://core-refactor-multi-chain-codes.d22tqykss69onq.amplifyapp.com/ |
LIQ-866 core/ui - Rename src/services to src/market, gathering the common method in one abstract class, named as Store. - Decouple BlockchainType for classes declartion, using instanceof to check whether the instance is CandyShop or EthCandyShop and perform differently if needed. - Make Auctionner as the interface to be optionally implemented. core/sdk - Refactor string in BlockchainType enum - Remove uncommon getters in BaseShop and clean redundant imports. - Move connection getter above constructor in CandyShop class - Fix the export in shop/index.ts to expose the Model files.
haVincy
force-pushed
the
core/refactor-multi-chain-codes
branch
from
0121ef1 to
317ff48
Compare
haVincy
commented
Oct 30, 2022
| () => AuctioneerFactory({ candyShop, blockchain, wallet }), | ||
| [candyShop, blockchain, wallet] | ||
| ); | ||
| const store = useMemo(() => StoreProvider({ candyShop, wallet }), [candyShop, wallet]); |
There was a problem hiding this comment.
@beepsaidblue @vanminh1701 I was wondering if it's good that we just add check here to avoid EthCandyShop to use Auctions. What do you guys think?
if (!(candyShop instanceof CandyShop)) {
// return something empty component
}There was a problem hiding this comment.
NVM, I just realize if the shopAddress doesn't have Auction data, it's will be empty. I think maybe no need to add this redundant codes.
vanminh1701
approved these changes
Oct 31, 2022
RustySol
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.