fix: update OrderDetail union types #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haVincy
reviewed
Oct 12, 2022
| @@ -70,8 +88,7 @@ export const OrderDetail: React.FC<OrderDetailProps> = ({ | |||
|
|
|||
| if (order && !nftInfo) { | |||
| setLoadingNftInfo(true); | |||
| candyShop | |||
| .nftInfo(order.tokenMint) | |||
| fetchNFTByMintAddress(order.tokenMint) | |||
haVincy
approved these changes
Oct 12, 2022
neversaynever0502
force-pushed
the
ui/update-order-detail--union-types
branch
from
216729f to
c364807
Compare
RustySol
approved these changes
Oct 12, 2022
neversaynever0502
force-pushed
the
ui/update-order-detail--union-types
branch
5 times, most recently
from
d099433 to
c21f7dc
Compare
…c component have flexibility [LIQ-767]
neversaynever0502
force-pushed
the
ui/update-order-detail--union-types
branch
from
c21f7dc to
96526cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the main UI components: OrderDetail in public all need candyShop: CandyShop as prop but the methods they called from sdk now can use without the CandyShop instance but just currencySymbol or partial infos.
To avoid breaking backward compatibility, I use union-types that can serve OrderDetail with partial shop info without CandyShop instance.