LIQ-732: POC websocket client #375
Conversation
vanminh1701
force-pushed
the
poc/websocket
branch
from
77f2a35 to
c8624c5
Compare
vanminh1701
force-pushed
the
poc/websocket
branch
2 times, most recently
from
0530304 to
a346192
Compare
| @@ -104,6 +109,22 @@ export const Drops: React.FC<DropsProps> = ({ candyShop, wallet, walletConnectCo | |||
| }); | |||
| }; | |||
|
|
|||
| // socket | |||
| useEffect(() => { | |||
| const controllers = [ | |||
There was a problem hiding this comment.
Curious, we declare the controllers here, wouldn't the reference will be changed every time once component renders, so the purpose here is we need to add the listeners and clean the listeners every time when component is being mounting / unmounting?
There was a problem hiding this comment.
actually, removeControllers will be run every time useEffect re-run. If we dont remove controllers at that time, the listeners are stil there and we will have more than 1 listeners for 1 event, the result maybe we will add duplicate item to list and display on UI, or some unexpected results. So better just clean it every useEffect re-run or unmount phase.
There was a problem hiding this comment.
okay, that sounds good and it's the desired result we want to avoid heap grows.
vanminh1701
force-pushed
the
poc/websocket
branch
from
a346192 to
c2887b6
Compare
socket auction integrate auction, order, drop remove polling code remove unused code upadte comment update env websocket add socket url and trade event for sell
vanminh1701
force-pushed
the
poc/websocket
branch
from
846dbb2 to
c2e9549
Compare
No description provided.