[LIQ-726] Edition Drop Feature #324

broskicodes · 2022-08-03T02:40:07Z

No description provided.

haVincy

How can we escape the dups in V1 and V2 to maintain or iterate the codes now? Any idea?

core/sdk/src/CandyShop.ts

core/sdk/src/EditionDrop.ts

core/sdk/src/factory/program/v2/editionDrop/enterpriseCommitNft.ts

core/sdk/src/vendor/utils/programUtils.ts

broskicodes · 2022-08-03T21:37:23Z

How can we escape the dups in V1 and V2 to maintain or iterate the codes now? Any idea?

You mean the dups between auction and marketplace v1/v2? I believe @RustySol wanted to keep them so that we can update v2 ixs without impacting v1.

haVincy · 2022-08-04T06:53:30Z

You mean the dups between auction and marketplace v1/v2?

Yes... it seems we will keep growing those and need double work to maintain or fix any issue.

I believe @RustySol wanted to keep them so that we can update v2 ixs without impacting v1.

I've talked about this to RustySol last time while refactoring the structures. RustySol, do you have any idea how do we reduce the work here.

core/sdk/src/CandyShop.ts

core/sdk/src/CandyShopDrop.ts

core/sdk/src/factory/constants.ts

core/sdk/src/vendor/error.ts

broskicodes · 2022-08-04T15:42:14Z

Yes... it seems we will keep growing those and need double work to maintain or fix any issue.

I believe that the intent is to leave v1 as is forever now, possibly deprecate in the future (@RustySol please confirm), and only update v2 going forward

RustySol · 2022-08-05T02:07:37Z

Yes... it seems we will keep growing those and need double work to maintain or fix any issue.

I believe that the intent is to leave v1 as is forever now, possibly deprecate in the future (@RustySol please confirm), and only update v2 going forward

Yes this is the plan I believe

haVincy

Please help to make it a one commit with descriptive content before merge.

RustySol · 2022-08-08T13:11:56Z

Edition Drop

Edition Drop feature empowers creator by selling Copies based on the Master Edition NFT.
Buyers will get a randomized Edition numbered copy upon mint.

2 Main operations included in this PR are

commitMasterNft: Master Edition owner will use this to transfer the Master Edition NFT into a vault to kickstart the sale of the corresponding copies.
mintNewPrint: Edition NFT Buyers will use this to Mint out randomized edition-ed NFTs.

@liqnft/candy-shop-types -> 0.2.22 @liqnft/candy-shop-sdk -> 0.5.23

broskicodes requested review from RustySol and haVincy August 3, 2022 02:40

haVincy reviewed Aug 3, 2022

View reviewed changes