[core] Add Stripe credit card payment support #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test link - https://core-stripe-payment.d22tqykss69onq.amplifyapp.com/ |
haVincy
force-pushed
the
core/stripe-payment
branch
2 times, most recently
from
e65900f to
7f479e3
Compare
vanminh1701
force-pushed
the
core/stripe-payment
branch
from
ab1f107 to
7f479e3
Compare
haVincy
force-pushed
the
core/stripe-payment
branch
2 times, most recently
from
65b25f9 to
642b1af
Compare
haVincy
force-pushed
the
core/stripe-payment
branch
5 times, most recently
from
7629b70 to
b0a1585
Compare
haVincy
force-pushed
the
core/stripe-payment
branch
from
b4d980c to
545602c
Compare
[LIQ-624] Prototype credit card payment in CandyShop Setup - Create CandyShopPayProvider to provide payment setup for children - Config to provide the Stripe public key for CandyShopPayProvider Add Payment folder under src/components - StripePayment.tsx to enable stripe.js if stripe pubkey is provided - StripeCardDetail.tsx to use CardElement from stripe UI - Get Order's ShopId for StripePayment
Modify the logic to avoid showing Credit Card Button while StripePubkey is not provided. - Add PaymentErrorName enum to differentiate payment error after catched - Add CreditCardPayAvailability enum to determin the disabled case while InsufficientPurchaseBalance or BelowMinPurchasePrice error occurs - Refactor the useCallback calls on APIs - Only fetch the checkPaymentAvailability when haven't fetched - Do not show the Credit Card Pay CTA on those not allowed tokens
Co-authored-by: tvminh <[email protected]>
PaymentService will not expose the stripePaymentId to client but the entityId to let client continue calling the confirm with that info to Server. Fix the BuyModalState when error or failed case occurs from processing CandyShopPay.confirmPayment. - We should also handle other errors, not only purchase or transfer to abort the processing state and show the error modal.
haVincy
force-pushed
the
core/stripe-payment
branch
from
affff4c to
6cc9f84
Compare
haVincy
force-pushed
the
core/stripe-payment
branch
from
6cc9f84 to
e3948d0
Compare
haVincy
force-pushed
the
core/stripe-payment
branch
from
e3948d0 to
2c3f800
Compare
RustySol
approved these changes
Aug 28, 2022
| export interface PaymentErrorDetails { | ||
| title: string; | ||
| content: string; | ||
| moreInfo?: PaymentErrorMoreInfo; |
There was a problem hiding this comment.
suggestion: can name it PaymentErrorExtra
There was a problem hiding this comment.
That's the relevant object matches to current payment-service
| @@ -12,3 +12,5 @@ export * from './public/Modal'; | |||
|
|
|||
| export { TransactionState, OrderDefaultFilter } from './model'; | |||
| export { CandyContext, CandyShopDataValidator } from './public/Context/CandyShopDataValidator'; | |||
| /* Don't export every usages from contexts */ | |||
There was a problem hiding this comment.
/* Don't export every usage from context */
There was a problem hiding this comment.
The folder is named contexts under ui/src/ so I wrote contexts here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.