Remove nalgebra from api #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhirtz
force-pushed
the
remove-nalgebra-from-api
branch
from
3d3766b
to
cd58268
Compare
Also don't enable the default "alga" feature for sprs, since alga is unmaintained and to-be-replaced by simba: https://github.com/dimforge/alga/tree/dev/alga#readme
by using nalgebra::SVector and SMatrix, which use const generics.
hhirtz
force-pushed
the
remove-nalgebra-from-api
branch
from
cd58268
to
58cb319
Compare
hhirtz
commented
Sep 21, 2021
| @@ -126,7 +126,7 @@ mod tests { | |||
| let w = [1, 2, 3, 4, 5, 6]; | |||
| let mut part = vec![0 as usize; w.len()]; | |||
| let imb_ini = imbalance::imbalance(2, &part, &w); | |||
| vn_best_mono(&mut part, &w, 2); | |||
| vn_best_mono::<u32>(&mut part, &w, 2); | |||
There was a problem hiding this comment.
VnBest now requires its generic type to be specified, otherwise rust fails with this weird, seemingly unrelated error:
error[E0275]: overflow evaluating the requirement `for<'r> &'r OPoint<_, _>: Sub`
--> src/lib.rs:756:9
|
756 | algorithms::vn::best::vn_best_mono(&mut ids, &weights_real, self.num_parts);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: src/algorithms/vn/best.rs:11:8
|
11 | pub fn vn_best_mono<T>(partition: &mut [usize], criterion: &[T], nb_parts: usize) -> RunInfo
| ------------ required by a bound in this
...
14 | for<'a> &'a T: Sub<Output = T>,
| --------------- required by this bound in `vn_best_mono`
|
= help: consider adding a `#![recursion_limit="256"]` attribute to your crate (`coupe`)
= note: required because of the requirements on the impl of `for<'r> Sub` for `&'r CsMatBase<OPoint<_, _>, _, _, _, _, _>`
= note: 125 redundant requirements hidden
= note: required because of the requirements on the impl of `for<'a> Sub` for `&'a CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<CsMatBase<OPoint<_, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>, _, _, _, _, _>`
There was a problem hiding this comment.
Follow-up on sparsemat/sprs#295
| @@ -461,7 +461,7 @@ mod tests { | |||
| let mbr = Mbr::from_points(&points); | |||
| let aspect_ratio = mbr.aspect_ratio(); | |||
|
|
|||
| relative_eq!(aspect_ratio, 4.); | |||
| assert_relative_eq!(aspect_ratio, 4.); | |||
There was a problem hiding this comment.
approx has labeled relative_eq as #[must_use] and, indeed, it's assert_relative_eq! that must be used here.
The following tests now fail:
geometry::tests::test_inertia_vector_3d
geometry::tests::test_mbr_2d
geometry::tests::test_mbr_3d
geometry::tests::test_mbr_distance_to_point_2d
geometry::tests::test_mbr_distance_to_point_3d
This was referenced Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler version of #3 where nalgebra's const-generic types are used instead of creating our own.
As said in the linked PR, I think this'll need to wait for
generic_const_exprsto be used in nalgebra.